Watchdog refactoring #9243
Closed
Watchdog refactoring #9243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajkan01
changed the title
|
@ARMmbed/mbed-os-hal |
Member
|
@rajkan01, thank you for your changes. |
Contributor
|
@rajkan01 Please take a look at the |
bulislaw
reviewed
Jan 3, 2019
ghost
reviewed
Jan 9, 2019
ghost
reviewed
Jan 9, 2019
ghost
reviewed
Jan 9, 2019
ghost
reviewed
Jan 9, 2019
rajkan01
force-pushed
the
feature-watchdog-v1
branch
from
5eb9f99 to
50c9315
Compare
rajkan01
force-pushed
the
feature-watchdog-v1
branch
5 times, most recently
from
6baae33 to
e4a0619
Compare
c1728p9
reviewed
Jan 16, 2019
rajkan01
force-pushed
the
feature-watchdog-v1
branch
from
e4a0619 to
7423433
Compare
-Added API to register muliple threads to watchdog drivers -Watchdog timeout reconfigures everytime whenever new register thread with longer timeout period -New APIs for watchdog wd_register(const osThreadId_t tid, const uint32_t timeout) to register to watchdog wd_unregister(const osThreadId_t tid) to unregister to watchdog kick(const osThreadId_t tid) to refresh the watchdog
- mbed_watchdog_mgr has interface name mbed_wdog_manager_start(),mbed_wdog_manager_stop(),mbed_wdog_manager_kick()
- HwWatchdog is going to attach with LowPowerTIcker for periodic callback functionality
- mbed_wdog_manager_start() will either get start either by BL/RTOS Aps,it reads the timeout value specified via macro and macro gets defined in target.json file.
- mbed_wdog_manager_start() internally configure below HAL hw watchdog with timeout specified via target.json
- mbed_wdog_manager_start() internally divide the timeout(specified in target.json) by the 2 and attach LowPowerTicker with periodic callback of hw_kick()
- mbed_wdog_manager_start() internally create one instance of sw watchdog class,to access the static list data structure of sw watchdog class
- mbed_wdog_manager_kick() function periodically get called and refresh the hw watchdog to avoid watchdog reset
- converted C++ code into C based APIs
- added boolean to control watchdog start and stop
- Added detach from ticker on stop API
-SW watchdog has interface name start(),stop(),kick() Sw watchdog internally has static list and shared across multiple instance of SW watchdog
- Sw watchdog initialize timeout value,unique string via constructor whenever threads created sw watchdog object
-Threads make sure pass proper timeout value,Unique string while creating the instance.
-start() called by components(BLE,WIFI etc.,),it adds the entry into static list with few details current count ,etc.,
-kick() called by registered components(BLE,WIFI etc.) to reset current count to zero.
-is_alive - interface API to mbed_watchdog_manager
-implementation optimization
- Added Hw watchdog periodic kick calls software watchdog is_alive check
-Added the unit test case for testing Hw watchdog
-Added the supported stubs files
-Added the mock class function to mock mbed_assert_internal -Added the unit test case to test start,kick,stop -Modified the interface api name from is_alive to process -added the unit test cases for process
rajkan01
force-pushed
the
feature-watchdog-v1
branch
from
88d84bc to
a628339
Compare
Contributor
|
As it was recently rebased, it might still need one more - conflicts above. |
Contributor
|
reviewing the history, this PR includes commits from master. needs clean-up |
Contributor
Author
|
After multiple rebase with master and origin/feature-watchdog it leads to complete cleanup by go through all commit which is complex so created the new pull request |
Contributor
|
Closing since from what I understand
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pull request type
Reviewers
@mbed-os-hal