Cellular: Added API for setting default parameters to a network inter… #9287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved methods to classes CellularDevice and CellularInformation. SIM interface was removed to simplify cellular usage and methods better suite new classes. Updated greentea and unit tests.
-added an API for checking network eps ciot optimization support -renamed the API for getting the UE parameters -the API for setting the UE parameters includes now a callback, which will be called once network support for eps ciot optimization is known
Cellular: Remove sim interface
…n_feature_branch Cellular ciot eps on feature branch
Cell refactor power api
Cellular: changed support features to CellularProperty array.
After this change we were able to change methods ATHandler::set_urc_handler and CellularDevice::set_ready_cb to void and simplify error handling.
Cellular: Removed unnecessary checks after new
This change enables removing function has_registration from class AT_CellularNetwork and all targets inheriting AT_CellularNetwork.
After AT_CellularNetwork::has_registration was replaced with CellularProperties and better AT_CellularNetwork::set_access_technology_impl default implementation we can delete most of the target specific classes that inherit AT_CellularNetwork.
Change usage of AT_CellularContext::stack_type_supported to AT_CellularBase::get_property. This way we can rid of targets overriding stack_type_supported and delete unnecessary classes and simplify new targets.
Generic cellular module (GENERIC_AT3GPP) can by used as a default module when porting new cellular module. It's a good starting point and eases porting of new modules. GENERIC_AT3GPP uses only standard 3GPP AT commands when communicating with the modem.
_sim_pin was changed to pointer from array and length was checked with strlen. If _sim_pin was null it caused crash. Fix by checking _sim_pin against NULL. Power class could have been called without checking if power is NULL. Fix by checking that power class is not null. Fix state machine to return correct states when queried.
Cellular: Add generic cellular modem
Cellular: added setting of data carrier support for UART.
I'm not sure about the cherry picking commit. It ran into conflict because travis file was many commits behind. I took the content as it is now in master. Is that ok? |
|
yes, should be |
|
Trying a thing. Standby. |
|
This is getting really annoying... |
|
This will go into CI once 5.11.2 RC test completes (soon in the current queue) |
mirelachirica
commented
Jan 14, 2019
mirelachirica
force-pushed
the
feature-cellular-refactor_nonip_app
branch
from
85047bb
to
d2d8215
Compare
|
CI started |
Test run: FAILEDSummary: 1 of 1 test jobs failed Failed test jobs:
|
…face A network interface instantiated directly is initially unconfigured. This API can be used to set the default parameters that would have been set if the interface had been requested using NetworkInterface::get_default_instance()
Corrected simplified astyle job behavior when base branch is not master Consolidated efforts from PR ARMmbed#9336. Previous job's env vars would not be populated correctly if the base branch of a PR was not master. Corected by pulling remaining respository information to perform comparison between read-only instance of PR and base branch.
mirelachirica
force-pushed
the
feature-cellular-refactor_nonip_app
branch
from
d2d8215
to
d6c42f7
Compare
|
Fixed the CI UT linking error |
|
CI started |
Test run: FAILEDSummary: 1 of 7 test jobs failed Failed test jobs:
|
0xc0170
force-pushed
the
feature-cellular-refactor
branch
from
6b0639d
to
007caa0
Compare
|
Latest rebase caused few conflicts here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added API for setting default parameters to a network interface.
Reason:
A network interface instantiated directly is initially unconfigured. This API can be used to set the default parameters that would have been set if the interface had been requested using NetworkInterface::get_default_instance().
This is needed when instantiating NonIP cellular interface for example and NetworkInterface::get_default_instance() cannot be used.
Pull request type