Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TRNG checkup in devicekey #9302

Merged
merged 1 commit into from
Jan 24, 2019
Merged

Add TRNG checkup in devicekey #9302

merged 1 commit into from
Jan 24, 2019

Conversation

yossi2le
Copy link
Contributor

@yossi2le yossi2le commented Jan 9, 2019

Description

To eliminate the case in which TRNG return success but actually fail and did nothing I have added a check that test if the device key buffer has changed after calling entropy function.
This checkup is not a bulletproof mechanism but we believe that it should decrease the chances for such an error in substantially.

This PR is dependant on #9278

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@boomer41
Copy link
Contributor

boomer41 commented Jan 9, 2019 •
edited
Loading

Actually I believe when such a case happens, the TRNG itself is broken. When it fails, but still returns success, the TRNG itself has a very big bug.

But nonetheless, adding such a check can be quite useful when a bug in the hal layer occurs.

@yossi2le yossi2le changed the title Yossi add trng checkup devicekey Add trng checkup in devicekey Jan 9, 2019
@yossi2le yossi2le changed the title Add trng checkup in devicekey Add TRNG checkup in devicekey Jan 9, 2019
@ciarmcom ciarmcom requested review from a team January 9, 2019 10:00
@ciarmcom
Copy link
Member

ciarmcom commented Jan 9, 2019

@yossi2le, thank you for your changes.
@ARMmbed/mbed-os-storage @ARMmbed/mbed-os-maintainers please review.

davidsaada
davidsaada approved these changes Jan 9, 2019
View reviewed changes
Copy link
Contributor

@davidsaada davidsaada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@yossi2le yossi2le force-pushed the yossi_add_trng_checkup_devicekey branch from 19b2a9c to 29c9123 Compare January 9, 2019 10:22
@cmonr
Copy link
Contributor

cmonr commented Jan 9, 2019

@yossi2le Please remove the second commit in this branch by rebasing this branch instead of merging the read-only reference into this one.

I have no idea what kind of problems trying to bring this into 5.11.2 would cause with that commit, but I would wager it wouldn't be pretty.

@mbed-ci
Copy link

mbed-ci commented Jan 10, 2019

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test

Adding a test if device key buffer has changed after calling to entro…
2adf5db 
…py func. this should enable as to eliminate some rare cases when the trng fail but still return success.
@yossi2le yossi2le force-pushed the yossi_add_trng_checkup_devicekey branch from 29c9123 to 2adf5db Compare January 10, 2019 08:22
@0xc0170
Copy link
Contributor

0xc0170 commented Jan 23, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Jan 23, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 2
Build artifacts

@cmonr cmonr merged commit b0b4013 into ARMmbed:master Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@dannybenor dannybenor dannybenor approved these changes

@davidsaada davidsaada davidsaada approved these changes

Assignees
No one assigned
Labels
release-version: 5.11.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@yossi2le @boomer41 @ciarmcom @cmonr @mbed-ci @0xc0170 @dannybenor @davidsaada