Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doxygen update for LoRaRadio class #9330

Merged
merged 3 commits into from
Jan 14, 2019
Merged

Doxygen update for LoRaRadio class #9330

merged 3 commits into from
Jan 14, 2019

Conversation

hasnainvirk
Copy link
Contributor

Description

Added more documentation to the data structures and corrected the
inclusion of this class to the correct class hierarchy.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[X] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@melwee01 @AnotherButler @AnttiKauppila

@0xc0170 0xc0170 requested a review from a team January 10, 2019 13:25
AnttiKauppila
AnttiKauppila suggested changes Jan 10, 2019
View reviewed changes
Copy link

@AnttiKauppila AnttiKauppila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small typo

Hasnain Virk and others added 3 commits January 11, 2019 11:29
Doxygen update for LoRaRadio class
8ed521e 
Added more documentation to the data structures and corrected the
inclusion of this class to the correct class hierarchy.
Writer review
701bb05 
Grammatical changes, passive -> active in some places, and future -> present.
Fixed single space that astyle caught
fd04d25
@0xc0170
Copy link
Contributor

0xc0170 commented Jan 11, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Jan 11, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit 7a5192f into ARMmbed:master Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnttiKauppila AnttiKauppila AnttiKauppila requested changes

@0xc0170 0xc0170 0xc0170 approved these changes

@melwee01 melwee01 melwee01 approved these changes

Assignees
No one assigned
Labels
release-version: 5.11.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@hasnainvirk @0xc0170 @mbed-ci @AnttiKauppila @melwee01 @cmonr @NirSonnenschein