ESP8266: prevent WOULD BLOCK from TX if UDP #9331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 10, 2019 14:33
With TCP it's desirable that SIGIO wakes up the application to check if there is buffer space space available on the mode. With UDP the behavior is not acceptable as we don't know if the other endpoint is there as connection establishment is missing. Hence buffers might stay full forever.
ciarmcom
requested review from
kjbracey,
michalpasztamobica,
SeppoTakalo and
a team
|
@VeijoPesonen, thank you for your changes. |
| _global_event_queue->call_in(100, callback(this, &ESP8266Interface::event)); | ||
| } else if (status == NSAPI_ERROR_WOULD_BLOCK && socket->proto == NSAPI_UDP) { | ||
| status = NSAPI_ERROR_DEVICE_ERROR; |
There was a problem hiding this comment.
Why do we need to modify the NSAPI_ERROR_WOULD_BLOCK to become NSAPI_ERROR_DEVICE_ERROR?
There was a problem hiding this comment.
I think because UDP sending should never fail.
SeppoTakalo
approved these changes
Jan 10, 2019
|
@0xc0170 would you please review. |
michalpasztamobica
approved these changes
Jan 16, 2019
0xc0170
approved these changes
Jan 16, 2019
|
CI started |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
0xc0170
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[ESP8266] Drop signalling SIGIO artificially if UDP send fails
With TCP it's desirable that SIGIO wakes up the application to check
if there is buffer space available on the mode. With UDP the
behavior is not acceptable as we don't know if the other endpoint is
there as connection establishment is missing. Hence buffers might
stay full forever.
Fix a debug print
Pull request type
Reviewers
@kjbracey-arm
@SeppoTakalo
@michalpasztamobica