Flush ESP8266 serial input buffers after HW reset #9341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmonr
requested review from
VeijoPesonen,
michalpasztamobica and
lauri-piikivi
cmonr
approved these changes
Jan 10, 2019
VeijoPesonen
approved these changes
Jan 11, 2019
0xc0170
approved these changes
Jan 11, 2019
|
starting CI |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
michalpasztamobica
approved these changes
Jan 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Flush ESP8266 serial input buffers after HW reset.
Without flushing the input buffers, there was a sight change that partially outputted lines were already in UARTSerial buffers, causing some wrong OOB handlers to be called and leading to parsing failures.
Problem reported in https://jira.arm.com/browse/ONME-4120
Pull request type
Reviewers
@VeijoPesonen @michalpasztamobica