Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameterise the repo used in the Mbed TLS importer script #9355

Merged
merged 1 commit into from
Jan 14, 2019

Conversation

simonbutcher
Copy link
Contributor

Description

This PR makes the repo used by the Mbed TLS import script a possible parameter to enable new Mbed TLS versions to be imported into Mbed OS from a repo different from the default. This change allows CI scripts (and any other script or users) to specify specific repos to use for testing.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[x] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@hanno-arm, @Patater

This commit makes the repo used to import new Mbed TLS versions into Mbed OS
a parameter, to allow CI scripts (and any other script or users) to specify
specific repos to use for testing.
@ciarmcom ciarmcom requested review from hanno-becker, Patater and a team January 11, 2019 14:00
@ciarmcom
Copy link
Member

@sbutcher-arm, thank you for your changes.
@hanno-arm @Patater @ARMmbed/mbed-os-tls @ARMmbed/mbed-os-maintainers please review.

Copy link
Contributor

@Patater Patater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@hanno-becker hanno-becker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 11, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Jan 11, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants