Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ESP8266: add an error check for data overflow from modem side #9366

Merged
merged 1 commit into from
Jan 18, 2019
Merged

ESP8266: add an error check for data overflow from modem side #9366

merged 1 commit into from
Jan 18, 2019

Conversation

VeijoPesonen
Copy link
Contributor

Description

Addresses issue ARMmbed/esp8266-driver#85. In case ESP8266's firmware misbehaves and sends more data than requested there is need to report a fatal error as overflow has occurred in this situation. This is just a precaution and hasn't been seen happening.

Pull request type

[ ] Fix
[X] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@SeppoTakalo
@michalpasztamobica

@ciarmcom
Copy link
Member

@VeijoPesonen, thank you for your changes.
@SeppoTakalo @michalpasztamobica @ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested review from SeppoTakalo and a team January 14, 2019 12:00
@VeijoPesonen VeijoPesonen changed the title [ESP8266] adds an error check for data overflow from modem side ESP8266 - adds an error check for data overflow from modem side Jan 14, 2019
@0xc0170 0xc0170 changed the title ESP8266 - adds an error check for data overflow from modem side ESP8266: add an error check for data overflow from modem side Jan 14, 2019
@0xc0170
Copy link
Contributor

0xc0170 commented Jan 17, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Jan 18, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@cmonr cmonr merged commit 30e0d8f into ARMmbed:master Jan 18, 2019
@VeijoPesonen VeijoPesonen deleted the bugfix-esp8266_verify_rcvd_data_len branch January 22, 2019 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

@SeppoTakalo SeppoTakalo SeppoTakalo approved these changes

@michalpasztamobica michalpasztamobica Awaiting requested review from michalpasztamobica

Assignees
No one assigned
Labels
release-version: 5.11.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@VeijoPesonen @ciarmcom @0xc0170 @mbed-ci @cmonr @SeppoTakalo