Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSOC6: Fixes for serial hal driver, asynchronous mode. #9368

Merged
merged 2 commits into from
Jan 24, 2019

Conversation

lrusinowicz
Copy link
Contributor

@lrusinowicz lrusinowicz commented Jan 14, 2019

Description

This commit fixes a number of more and less subtle bugs in a serial hal driver for PSoC6. Mostly TX/RX typos and incorrect events processing.

mbed tests log:
tests_sequana_gcc_20190114.log

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@ciarmcom ciarmcom requested a review from a team January 14, 2019 12:00
@ciarmcom
Copy link
Member

@lrusinowicz, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@cmonr
Copy link
Contributor

cmonr commented Jan 17, 2019

CI started

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 17, 2019

One breakage on master needs to be addressed asap, the current build was aborted and will be restarted within today.

@mbed-ci
Copy link

mbed-ci commented Jan 17, 2019

Test run: FAILED

Summary: 1 of 7 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-IAR

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 18, 2019

Failures are not related (only errors I spot are from not supported tests, no real errors). I'll check once again and restart CI if that is true

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 18, 2019

CI restarted

@mbed-ci
Copy link

mbed-ci commented Jan 18, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 2
Build artifacts

@lrusinowicz
Copy link
Contributor Author

@0xc0170
Hi Martin,
Unfortunately, I have found one another fix required for asynchronous API in this file. Would it be OK for me to amend this PR at this stage, or should I prepare another one?

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 21, 2019

Lets amend it here, I set it as needs work

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 21, 2019

All fixed now?

@lrusinowicz
Copy link
Contributor Author

@0xc0170
Yes, now it's complete.

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 23, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Jan 23, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 3
Build artifacts

@cmonr cmonr merged commit 0c6f0e4 into ARMmbed:master Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants