Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

travis: set hypothesis to v3.88 #9371

Merged
merged 1 commit into from
Jan 14, 2019
Merged

Conversation

0xc0170
Copy link
Contributor

@0xc0170 0xc0170 commented Jan 14, 2019

Description

Fixing travis test package that got minor update today and broke our tests

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@0xc0170
Copy link
Contributor Author

0xc0170 commented Jan 14, 2019

@ARMmbed/mbed-os-tools I suspect that hypothesis broke in their latest update

Update to v4.x breaks tools, will need to be addressed separately.
@ciarmcom ciarmcom requested a review from a team January 14, 2019 16:00
@ciarmcom
Copy link
Member

@0xc0170, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor Author

0xc0170 commented Jan 14, 2019

travis-ci/tools-py2.7 — Local tools-py2.7 testing has passed

I removed the testing commit, setting hypothesis package back to <4.x version fixes this issue.

@0xc0170 0xc0170 requested a review from a team January 14, 2019 16:02
@@ -107,7 +107,7 @@ matrix:
# Install dependencies
- sudo apt-get install gcc-arm-embedded
- pip install -r requirements.txt
- pip install pytest pylint hypothesis mock coverage coveralls
- pip install pytest pylint hypothesis==3.88.3 mock coverage coveralls
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the latest known working version, setting it for now

@0xc0170 0xc0170 changed the title Do not merge: testing travis travis: set hypothesis to 3.88 fixed version Jan 14, 2019
@0xc0170
Copy link
Contributor Author

0xc0170 commented Jan 14, 2019

Set 5.11.2 as it should unblock 5.11.2 RC

Copy link
Contributor

@adbridge adbridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xc0170 0xc0170 changed the title travis: set hypothesis to 3.88 fixed version travis: set hypothesis to v3.88 Jan 14, 2019
Copy link
Contributor

@bridadan bridadan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, we should be pinning the major versions of stable APIs anyway!

@adbridge
Copy link
Contributor

ci started

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants