Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UNO_91H: open hal lib source #9380

Merged
merged 1 commit into from
Jan 18, 2019
Merged

UNO_91H: open hal lib source #9380

merged 1 commit into from
Jan 18, 2019

Conversation

kyliuxing
Copy link
Contributor

@kyliuxing kyliuxing commented Jan 15, 2019 •
edited
Loading

Description

Adding source code to replace archives for convenience

Pull request type

[ ] Fix
[ ] Refactor
[x ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 15, 2019

Can you describe the changes using Description section?
Looking at the files, this is removing the closed source archives and adding sources?

@kyliuxing
Copy link
Contributor Author

Can you describe the changes using Description section?
Looking at the files, this is removing the closed source archives and adding sources?

yes,I have updated description

0xc0170
0xc0170 reviewed Jan 15, 2019
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small update, otherwise 👍 for replacing the closed source libs

targets/TARGET_RDA/TARGET_UNO_91H/rda_ccfg_api.c Outdated
@@ -0,0 +1,411 @@
/* mbed Microcontroller Library
* Copyright (c) 2006-2013 ARM Limited
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update this license heder file and use the newest one (including SPDX identifier) ?

features/cellular/framework/API/CellularContext.h is a good example

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done,Thanks!

@ciarmcom ciarmcom requested a review from a team January 15, 2019 12:13
@ciarmcom
Copy link
Member

@kyliuxing, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@0xc0170 0xc0170 changed the title open hal lib source UNO_91H: open hal lib source Jan 16, 2019
@0xc0170
Copy link
Contributor

0xc0170 commented Jan 16, 2019

I edited also the title (helps to be more specific - in this case what target is having this open source hal lib).

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 17, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Jan 18, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@cmonr cmonr merged commit c0bbc5c into ARMmbed:master Jan 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-version: 5.11.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kyliuxing @0xc0170 @ciarmcom @mbed-ci @cmonr