Fix TCPSOCKET_ENDPOINT_CLOSE: Cannot accept WOULD_BLOCK #9429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SeppoTakalo, thank you for your changes. |
VeijoPesonen
approved these changes
Jan 21, 2019
This testcase uses Socket in blocking mode, and therefore WOULD_BLOCK should not be accepted. The logic was wrong anyway, because return value was tested to be negative before testing with WOULD_BLOCK which is negative as well. Also replaced TEST_FAIL() macro with TEST_ASSERT_EQUAL() to make the return code visible in test log.
SeppoTakalo
force-pushed
the
TCPSOCKET_endpoint_close
branch
from
a34989d
to
6b92d32
Compare
|
@VeijoPesonen @KariHaapalehto Please review. |
VeijoPesonen
approved these changes
Jan 30, 2019
cmonr
approved these changes
Jan 30, 2019
|
CI started |
Test run: SUCCESSSummary: 10 of 10 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This testcase uses Socket in blocking mode, and therefore
WOULD_BLOCK should not be accepted.
The logic was wrong anyway, because return value was tested
to be negative before testing with WOULD_BLOCK which is negative
as well.
Also replaced TEST_FAIL() macro with TEST_ASSERT_EQUAL() to
make the return code visible in test log.
Pull request type
Reviewers
@VeijoPesonen @KariHaapalehto