Crypto platform renaming #9452
Merged
Crypto platform renaming #9452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Patater
reviewed
Jan 22, 2019
| @@ -24,5 +24,5 @@ To port your CC 310 driver to Mbed OS on your specific target, do the following: | |||
| 1. In `features/cryptocell/FEATURE_CRYPTOCELL310/TARGET_<target name>`, add your platform-specific libraries for all toolchains in `TOOLCHAIN_ARM`, `TOOLCHAIN_GCC_ARM` and `TOOLCHAIN_IAR` respectively. | |||
| 1. Add your CC setup code: | |||
| * Implement `crypto_platform_setup()` and `crypto_platform_terminate()` to enable CC on your platform, in case you have board-specific setup functionality, required for CC setup. You MUST call 'SaSi_LibInit()` and 'SaSi_LibFini()' respectively in these functions. | |||
| * Define `crypto_platform_ctx` in `crypto_platform.h` in a way that suits your implementation. | |||
| * Define `crypto_platform_ctx` in `crypto_device_platform.h` in a way that suits your implementation. | |||
There was a problem hiding this comment.
Is there any other documentation we need to update for this rename?
There was a problem hiding this comment.
There was a problem hiding this comment.
Raised ARMmbed/mbed-os-5-docs#929 to change the docc as well
added 2 commits
January 22, 2019 13:56
To avoid collisions between the psa `crypto_platform.h` file and the platform specific `crypto_platform.h` file, for the init \ terminate functions, rename the latter to `crypto_device_platform`.
Rename the generic name `ctx` of `mbedtls_platform_context` in `platform_alt.c` to a specific name `plat_ctx`, to avoid conflicts when used as external in crypto modules.
RonEld
force-pushed
the
crypto_platform_ranaming
branch
from
75eab97
to
cad40e1
Compare
|
@Patater Thank you for your review. |
|
@RonEld, thank you for your changes. |
0xc0170
approved these changes
Jan 22, 2019
Patater
approved these changes
Jan 22, 2019
|
CI started |
Test run: FAILEDSummary: 1 of 8 test jobs failed Failed test jobs:
|
|
Restarted CI |
Test run: FAILEDSummary: 1 of 12 test jobs failed Failed test jobs:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ctxofmbedtls_platform_contextin
platform_alt.cto a specific nameplat_ctx, to avoid conflictswhen used as external in crypto modules.
crypto_platform.hfile and theplatform specific
crypto_platform.hfile, for the init \ terminatefunctions, rename the latter to
crypto_device_platformPull request type
Reviewers
@ARMmbed/mbed-os-crypto