Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected the targets value in json file as CI uses real board names #9462

Merged
merged 1 commit into from
Jan 24, 2019

Conversation

deepikabhavnani
Copy link

Description

Sockets examples were not tested in CI, as CI uses real board names and not macros.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@OPpuolitaival

@ciarmcom ciarmcom requested review from OPpuolitaival and a team January 22, 2019 20:00
@ciarmcom
Copy link
Member

@deepikabhavnani, thank you for your changes.
@OPpuolitaival @ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

Copy link
Contributor

@bridadan bridadan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is more of maintainer's file than a tools file, but looks ok. It does looks like sometimes a K64F was chosen instead of a K66F, any reason for that? Or more general, how come certain targets are included for certain examples and not for others?

@deepikabhavnani
Copy link
Author

It does looks like sometimes a K64F was chosen instead of a K66F, any reason for that? Or more general, how come certain targets are included for certain examples and not for others?

All of the test are socket related, so instead of performing test on single target selected different ones for each test.

@cmonr
Copy link
Contributor

cmonr commented Jan 23, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Jan 23, 2019

Test run: FAILED

Summary: 1 of 8 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-ARMC6

@alekla01
Copy link
Contributor

Restarted CI

Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The previous values were not valid, and only these updated targets were selected anyway

Copy link
Contributor

@OPpuolitaival OPpuolitaival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good!

@mbed-ci
Copy link

mbed-ci commented Jan 23, 2019

Test run: FAILED

Summary: 1 of 12 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 23, 2019

CI restarted, it timeouted

@cmonr
Copy link
Contributor

cmonr commented Jan 24, 2019

CI job restarted: jenkins-ci/greentea-test

It appears to have timed out, but not sure 100%...

@cmonr cmonr merged commit f69b550 into ARMmbed:master Jan 24, 2019
@deepikabhavnani deepikabhavnani deleted the add_example branch January 25, 2019 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants