Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MIMXRT1050_EVK: Add IAR support in the exporter #9496

Merged
merged 1 commit into from
Jan 30, 2019
Merged

MIMXRT1050_EVK: Add IAR support in the exporter #9496

merged 1 commit into from
Jan 30, 2019

Conversation

mmahadevan108
Copy link
Contributor

Description

Add IAR support in the exporter for MIMXRT1050

Pull request type

[ ] Fix
[ ] Refactor
[X] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@theotherjimmy

@mmahadevan108
MIMXRT1050_EVK: Add IAR support in the exporter
aa449b3 
Signed-off-by: Mahesh Mahadevan <mahesh.mahadevan@nxp.com>
@mmahadevan108
Copy link
Contributor Author

cc @cmonr @0xc0170

@ciarmcom ciarmcom requested review from theotherjimmy and a team January 24, 2019 20:00
@ciarmcom
Copy link
Member

@mmahadevan108, thank you for your changes.
@theotherjimmy @ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

@mbed-ci
Copy link

mbed-ci commented Jan 28, 2019

Test run: FAILED

Summary: 1 of 12 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test

@cmonr
Copy link
Contributor

cmonr commented Jan 28, 2019

CI job restarted: jenkins-ci/greentea-test

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 29, 2019

Test restarted

@cmonr
Copy link
Contributor

cmonr commented Jan 29, 2019

CI job restarted: jenkins-ci/greentea-test

Failures appear to be completely unrelated to PR.

@0xc0170 0xc0170 merged commit 2a16bbd into ARMmbed:master Jan 30, 2019
@0xc0170
Copy link
Contributor

0xc0170 commented Feb 5, 2019

@mmahadevan108 What IAR version is required for this target? I'll create an issue as this target is failing nightly exporters for IAR

@0xc0170 0xc0170 mentioned this pull request Feb 5, 2019
Closed
@mmahadevan108
Copy link
Contributor Author

8.30

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 11, 2019

This should go in with feature-iar8 branch then. I'll revert this PR for 5.11.5 (fixing master exporters now)

@0xc0170 0xc0170 mentioned this pull request Feb 11, 2019
Merged
@mmahadevan108 mmahadevan108 deleted the Add_MXRT_IAR_Support branch April 22, 2019 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theotherjimmy theotherjimmy theotherjimmy approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

@bridadan bridadan bridadan approved these changes

Assignees
No one assigned
Labels
release-version: 5.11.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mmahadevan108 @ciarmcom @mbed-ci @cmonr @0xc0170 @theotherjimmy @bridadan