-
Notifications
You must be signed in to change notification settings - Fork 3k
BLE: Add MTU events #9537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BLE: Add MTU events #9537
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you document the ATT MTU and DLE behaviour ? When is it triggered automatically, when it is not ? It would be better to offer a consistent behaviour across ports. If we can't this must be documented.
@pan- All good with the updates? |
@cmonr I resolved what has been solved and left open what is not yet solved. |
I rerouted the event handling to gatt server and and client - this is tentative, must review on Monday |
features/FEATURE_BLE/targets/TARGET_CORDIO/CordioPalAttClient.cpp
Outdated
Show resolved
Hide resolved
@pan- , some additional changes here, can you please review the latest changes. |
@0xc0170 the system is not satisfied with Vincent's review sadly, can you help, please? |
Please add Release notes to the first comment, following https://os.mbed.com/docs/mbed-os/v5.11/contributing/workflow.html#functionality-change |
@@ -0,0 +1,74 @@ | |||
/* mbed Microcontroller Library | |||
* Copyright (c) 2019 ARM Limited | |||
* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add SPDX identifier to all new files please
thanks - added |
@AnotherButler Please review |
24a4ee5
to
d801ed3
Compare
CI restarted |
Test run: FAILEDSummary: 1 of 8 test jobs failed Failed test jobs:
|
looking at the logs looks like CI failure to me
|
Restarted CI |
Test run: SUCCESSSummary: 12 of 12 test jobs passed |
Description
Added events in the gap event handler to inform the user of ATT_MTU and packet payload size changes.
Pull request type
Reviewers
Release notes
This adds optional events for informing the user of MTU changes and an option to attempt an MTU negotiation.
There is no effect on existing users; the usage is optional and will not affect users who don't use it. There is no migration path because the events are a new feature.