Skip to content

BLE: Add MTU events #9537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Feb 15, 2019
Merged

BLE: Add MTU events #9537

merged 18 commits into from
Feb 15, 2019

Conversation

paul-szczepanek-arm
Copy link
Member

@paul-szczepanek-arm paul-szczepanek-arm commented Jan 29, 2019

Description

Added events in the gap event handler to inform the user of ATT_MTU and packet payload size changes.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[x] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release notes

This adds optional events for informing the user of MTU changes and an option to attempt an MTU negotiation.

There is no effect on existing users; the usage is optional and will not affect users who don't use it. There is no migration path because the events are a new feature.

Copy link
Member

@pan- pan- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you document the ATT MTU and DLE behaviour ? When is it triggered automatically, when it is not ? It would be better to offer a consistent behaviour across ports. If we can't this must be documented.

@cmonr
Copy link
Contributor

cmonr commented Jan 30, 2019

@pan- All good with the updates?

@pan-
Copy link
Member

pan- commented Jan 31, 2019

@cmonr I resolved what has been solved and left open what is not yet solved.

@paul-szczepanek-arm
Copy link
Member Author

paul-szczepanek-arm commented Feb 1, 2019

I rerouted the event handling to gatt server and and client - this is tentative, must review on Monday

@NirSonnenschein
Copy link
Contributor

@pan- , some additional changes here, can you please review the latest changes.

@paul-szczepanek-arm
Copy link
Member Author

paul-szczepanek-arm commented Feb 11, 2019

@0xc0170 the system is not satisfied with Vincent's review sadly, can you help, please?

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 11, 2019

Please add Release notes to the first comment, following https://os.mbed.com/docs/mbed-os/v5.11/contributing/workflow.html#functionality-change

@@ -0,0 +1,74 @@
/* mbed Microcontroller Library
* Copyright (c) 2019 ARM Limited
*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add SPDX identifier to all new files please

@paul-szczepanek-arm
Copy link
Member Author

thanks - added

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 11, 2019

@AnotherButler Please review

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 14, 2019

CI restarted

@mbed-ci
Copy link

mbed-ci commented Feb 14, 2019

Test run: FAILED

Summary: 1 of 8 test jobs failed
Build number : 6
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-ARM

@paul-szczepanek-arm
Copy link
Member Author

paul-szczepanek-arm commented Feb 14, 2019

looking at the logs looks like CI failure to me

Loading library mbed-os-ci@master
java.io.FileNotFoundException: https://api.github.com/repos/ARMmbed/mbed-os-ci
	at com.squareup.okhttp.internal.huc.HttpURLConnectionImpl.getInputStream(HttpURLConnectionImpl.java:243)
	at com.squareup.okhttp.internal.huc.DelegatingHttpsURLConnection.getInputStream(DelegatingHttpsURLConnection.java:210)
	at com.squareup.okhttp.internal.huc.HttpsURLConnectionImpl.getInputStream(HttpsURLConnectionImpl.java:25)
	at org.kohsuke.github.Requester.parse(Requester.java:617)
	at org.kohsuke.github.Requester.parse(Requester.java:599)
	at org.kohsuke.github.Requester._to(Requester.java:277)
Caused: org.kohsuke.github.GHFileNotFoundException: {
  "message": "Server Error"
}

@cmonr
Copy link
Contributor

cmonr commented Feb 15, 2019

Restarted CI

@mbed-ci
Copy link

mbed-ci commented Feb 15, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 7
Build artifacts

@0xc0170 0xc0170 changed the title BLE: Added MTU events BLE: Add MTU events Feb 15, 2019
@0xc0170 0xc0170 merged commit a7b9490 into ARMmbed:master Feb 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants