Improvement to artifact delivery method #9633

orenc17 · 2019-02-06T13:28:43Z

Description

A target can define a delivery directory instead of the default option

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[X] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@theotherjimmy

Release notes

When a target declares a deliver_to_target in targets.json the output binary will be copied to DELIVERY directory in the root of mbed-os.
We now allow to declare a path to where the deliverables will be delivered to by declaring delivery_dir in the the target in targets.json
delivery_dir is a relative to where it was last changed.
so we have the following scenarios:

delivery_dir not specified -> {mbed-os root}/DELIVERY/TARGET_{REQUESTED_TARGET}
delivery_dir specified in targets.json -> the path will be relative to targets folder inside mbed-os.
delivery_dir specified in mbed_app.json -> the path will be relative to that file's base folder.

A target can define a delivery directory instead of the default option

ciarmcom · 2019-02-06T14:00:43Z

@orenc17, thank you for your changes.
@theotherjimmy @ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

theotherjimmy

Back to where I started. Works for me.

adbridge · 2019-02-06T16:38:59Z

CI started, but still needs maintainer review

NirSonnenschein · 2019-02-07T08:07:10Z

@orenc17 please take a look at the CI failure - nevermind , unrelated CI issue

mikisch81

Perhaps we should change DELIVERY_DIR now to DEFAULT_DELIVERY_DIR?

alekla01 · 2019-02-07T09:07:20Z

Restarted CI

0xc0170 · 2019-02-07T09:40:50Z

Perhaps we should change DELIVERY_DIR now to DEFAULT_DELIVERY_DIR?

Why would you change it? I dont see anywhere in the config used DEFAULT_ ?

mbed-ci · 2019-02-07T11:23:45Z

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 5
Build artifacts

mikisch81 · 2019-02-07T11:50:55Z

@ARMmbed/mbed-os-maintainers does it really needs-work? eventually tests passed.

0xc0170 · 2019-02-07T11:56:38Z

needs: work

Functionality change should contain release notes section , please add it (following ARMmbed/mbed-os-5-docs#933)

mikisch81 · 2019-02-07T11:58:03Z

Perhaps we should change DELIVERY_DIR now to DEFAULT_DELIVERY_DIR?

Why would you change it? I dont see anywhere in the config used DEFAULT_ ?

Not really important.. thats why I approved.

orenc17 · 2019-02-07T12:07:36Z

@0xc0170 release notes added

orenc17 · 2019-02-07T12:59:18Z

@ARMmbed/mbed-os-maintainers could you please run the CI again once travis is done?

NirSonnenschein · 2019-02-07T13:57:45Z

starting CI

tools/config/__init__.py

mbed-ci · 2019-02-07T16:09:45Z

Test run: FAILED

Summary: 1 of 12 test jobs failed
Build number : 6
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_dynamic-memory-usage

tools/config/__init__.py

mikisch81 · 2019-02-07T17:26:22Z

LGTM
Did you check the scenario of building from inside/outside mbed-os folder?

orenc17 · 2019-02-07T17:34:12Z

LGTM
Did you check the scenario of building from inside/outside mbed-os folder?

Yes, it works flawlessly

mikisch81 · 2019-02-07T17:37:42Z

@theotherjimmy, delivery for was changed as you requested.

mikisch81

@0xc0170 Can we run CI?

We addressed @theotherjimmy remarks and waiting approval.

tools/config/__init__.py

Co-Authored-By: orenc17 <oren.cohen@arm.com>

NirSonnenschein · 2019-02-10T08:01:16Z

starting CI while we wait for technical writer review.

mbed-ci · 2019-02-10T10:17:26Z

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 7
Build artifacts

mikisch81 · 2019-02-11T15:10:56Z

@ARMmbed/mbed-os-maintainers No technical writer around?
Is it really necessary to postpone this PR like that?

mikisch81 · 2019-02-11T15:33:05Z

starting CI while we wait for technical writer review.

@AnotherButler

cmonr · 2019-02-11T19:28:22Z

@mikisch81 Talking with other maintainers on the Release Notes review. Seems odd to me as well that we'd block a PR on a description update.

Improvement to artifact delivery method

04a22a2

A target can define a delivery directory instead of the default option

ciarmcom requested review from theotherjimmy and a team February 6, 2019 14:00

ciarmcom added the needs: review label Feb 6, 2019

theotherjimmy approved these changes Feb 6, 2019

View reviewed changes

NirSonnenschein approved these changes Feb 7, 2019

View reviewed changes

NirSonnenschein added the needs: work label Feb 7, 2019

mikisch81 approved these changes Feb 7, 2019

View reviewed changes

0xc0170 removed the needs: review label Feb 7, 2019

0xc0170 approved these changes Feb 7, 2019

View reviewed changes

NirSonnenschein added needs: review ready for merge and removed needs: work needs: review labels Feb 7, 2019

0xc0170 added needs: work and removed ready for merge labels Feb 7, 2019

0xc0170 added ready for merge release-version: 5.12.0-rc1 and removed needs: work labels Feb 7, 2019

Make delivery_dir relative to mbed_os root

44c1a2c

theotherjimmy suggested changes Feb 7, 2019

View reviewed changes

tools/config/__init__.py Outdated Show resolved Hide resolved

0xc0170 added needs: work and removed needs: review labels Feb 7, 2019

Make delivery_dir relative to the json it was declared in

e162d69

mikisch81 reviewed Feb 7, 2019

View reviewed changes

tools/config/__init__.py Show resolved Hide resolved

mikisch81 approved these changes Feb 8, 2019

View reviewed changes

theotherjimmy reviewed Feb 8, 2019

View reviewed changes

tools/config/__init__.py Outdated Show resolved Hide resolved

theotherjimmy approved these changes Feb 8, 2019

View reviewed changes

mikisch81 reviewed Feb 8, 2019

View reviewed changes

tools/config/__init__.py Outdated Show resolved Hide resolved

Update tools/config/__init__.py

9013dc8

Co-Authored-By: orenc17 <oren.cohen@arm.com>

NirSonnenschein added needs: review and removed needs: work labels Feb 10, 2019

mikisch81 mentioned this pull request Feb 11, 2019

TF-M sources integration to Mbed-OS #9653

Merged

0xc0170 added ready for merge and removed needs: review labels Feb 11, 2019

0xc0170 merged commit 36df2aa into ARMmbed:master Feb 11, 2019

0xc0170 removed the ready for merge label Feb 11, 2019

lrusinowicz mentioned this pull request Feb 12, 2019

FUTURE_SEQUANA_PSA: fixed deep sleep mode #9678

Merged

Improvement to artifact delivery method #9633

Improvement to artifact delivery method #9633

Uh oh!

Conversation

orenc17 commented Feb 6, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Pull request type

Reviewers

Release notes

Uh oh!

ciarmcom commented Feb 6, 2019

Uh oh!

theotherjimmy left a comment

Choose a reason for hiding this comment

Uh oh!

adbridge commented Feb 6, 2019

Uh oh!

NirSonnenschein commented Feb 7, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mikisch81 left a comment

Choose a reason for hiding this comment

Uh oh!

alekla01 commented Feb 7, 2019

Uh oh!

0xc0170 commented Feb 7, 2019

Uh oh!

mbed-ci commented Feb 7, 2019

Test run: SUCCESS

Uh oh!

mikisch81 commented Feb 7, 2019

Uh oh!

0xc0170 commented Feb 7, 2019

Uh oh!

mikisch81 commented Feb 7, 2019

Uh oh!

orenc17 commented Feb 7, 2019

Uh oh!

orenc17 commented Feb 7, 2019

Uh oh!

NirSonnenschein commented Feb 7, 2019

Uh oh!

Uh oh!

mbed-ci commented Feb 7, 2019

Test run: FAILED

Uh oh!

Uh oh!

mikisch81 commented Feb 7, 2019

Uh oh!

orenc17 commented Feb 7, 2019

Uh oh!

mikisch81 commented Feb 7, 2019

Uh oh!

mikisch81 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

NirSonnenschein commented Feb 10, 2019

Uh oh!

mbed-ci commented Feb 10, 2019

Test run: SUCCESS

Uh oh!

mikisch81 commented Feb 11, 2019

Uh oh!

mikisch81 commented Feb 11, 2019

Uh oh!

cmonr commented Feb 11, 2019

Uh oh!

Uh oh!

orenc17 commented Feb 6, 2019 •

edited

Loading

NirSonnenschein commented Feb 7, 2019 •

edited

Loading