Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not provide a default Pelion host address. #9635

Merged
merged 1 commit into from
Feb 15, 2019
Merged

Do not provide a default Pelion host address. #9635

merged 1 commit into from
Feb 15, 2019

Conversation

bridadan
Copy link
Contributor

@bridadan bridadan commented Feb 6, 2019

Description

This moves the default pelion host address to be assigned by the cloud
sdk. It also cleans up the logic a bit to be shorter.

This pairs with ARMmbed/mbed-cli#840, though they aren't dependent on one other.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@theotherjimmy

@ciarmcom ciarmcom requested review from theotherjimmy and a team February 6, 2019 22:00
@ciarmcom
Copy link
Member

ciarmcom commented Feb 6, 2019

@bridadan, thank you for your changes.
@theotherjimmy @ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

@bridadan
Copy link
Contributor Author

bridadan commented Feb 7, 2019 •
edited
Loading

@ARMmbed/mbed-os-maintainers I'm reevaluating the use of the environment variables here, can you please hold off on CI and merging this for now?

@bridadan
Do not provide a default Pelion host address.
3ff0ca4 
This moves the default pelion host address to be assigned by the cloud
sdk. It also cleans up the logic a bit to be shorter.
@bridadan
Copy link
Contributor Author

Ok I'm happy with this now. Now we let the Cloud SDK library handle all of the environment variables. If we catch an exception when passing the config to the Cloud SDK, it means and API key wasn't supplied, so we catch the original exception and make the message a bit clearer with a call to action (mbed config ...).

@aashishc1988 could you review this change? It's a follow up to your PR here: ARMmbed/mbed-cli#838

This should fix #8144 as well as IOTCORE-867.

aashishc1988
aashishc1988 approved these changes Feb 11, 2019
View reviewed changes
Copy link
Contributor

@aashishc1988 aashishc1988 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@cmonr
Copy link
Contributor

cmonr commented Feb 11, 2019

CI started while we wait on the primarily requested reviewer.

@mbed-ci
Copy link

mbed-ci commented Feb 12, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

@bridadan bridadan mentioned this pull request Feb 13, 2019
Closed
@cmonr cmonr merged commit 6278ed6 into ARMmbed:master Feb 15, 2019
@bridadan bridadan mentioned this pull request Feb 20, 2019
Closed
@cmonr cmonr mentioned this pull request Feb 20, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr approved these changes

@theotherjimmy theotherjimmy theotherjimmy approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

@aashishc1988 aashishc1988 aashishc1988 approved these changes

Assignees
No one assigned
Labels
release-version: 5.11.5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@bridadan @ciarmcom @cmonr @mbed-ci @theotherjimmy @0xc0170 @aashishc1988