Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IntelliSense in VSCode export #9649

Merged
merged 3 commits into from
Feb 15, 2019
Merged

Conversation

ngraziano
Copy link
Contributor

Allow to use default intelliSenseEngine in visual studio code.
Add of compilerPath and forcedInclude of mbed_config header in the
created c_cpp_properties.json file.

Description

Allow to use default intelliSenseEngine in visual studio code.
Add of compilerPath and forcedInclude of mbed_config header in the
created c_cpp_properties.json file.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@ciarmcom ciarmcom requested a review from a team February 9, 2019 20:00
@ciarmcom
Copy link
Member

ciarmcom commented Feb 9, 2019

@ngraziano, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@0xc0170 0xc0170 requested review from a team and janjongboom February 11, 2019 09:17
@0xc0170
Copy link
Contributor

0xc0170 commented Feb 11, 2019

Thanks @ngraziano for the contribution. Our teams will review.

This PR is fixing #7863 ?

@ngraziano
Copy link
Contributor Author

ngraziano commented Feb 11, 2019

It should fix #7863 (You make me discover this issue).

But when reading #7863 (comment) , I see there is other improvement that can be added to the pull request :

  • I may change ${workspaceRoot} to ${workspaceFolder} (see VSCode Variables Reference)
  • I may change \\ to / on windows configuration to make easier to read.

Do I have to complete this PR or create another one ?

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 11, 2019

Can complete it if you have time now, while we review - adding separate commits. As these will be simple fixes

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 11, 2019

release-candidate

Please target master branch

Allow to use default intelliSenseEngine in visual studio code.
Add of compilerPath and forcedInclude of mbed_config header in the
created c_cpp_properties.json file.
VSCode handle "/" and it is easier to read.
Replace with ${workspaceFolder}
@ngraziano ngraziano changed the base branch from release-candidate to master February 11, 2019 18:06
@ngraziano
Copy link
Contributor Author

It should target master now.

@cmonr
Copy link
Contributor

cmonr commented Feb 11, 2019

@janjongboom Would you be able to locally test this PR on your machine to conform the VSCode changes?

Copy link
Contributor

@theotherjimmy theotherjimmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 15, 2019

@janjongboom Would you be able to locally test this PR on your machine to conform the VSCode changes?

While we are waiting, I'll start CI

@mbed-ci
Copy link

mbed-ci commented Feb 15, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants