Skip to content

Use new delivery for FUTURE_SEQUANA_PSA #9666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 25, 2019
Merged

Use new delivery for FUTURE_SEQUANA_PSA #9666

merged 2 commits into from
Feb 25, 2019

Conversation

orenc17
Copy link
Contributor

@orenc17 orenc17 commented Feb 11, 2019 •
edited
Loading

Description

Adapt FUTURE_SEQUANA_PSA & FUTURE_SEQUANA_M0_PSA to new artifact delivery system

Waits for #9708

Pull request type

[ ] Fix
[ ] Refactor
[X] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@ARMmbed/mbed-os-psa @ARMmbed/mbed-os-tools @lrusinowicz

@ciarmcom ciarmcom requested a review from a team February 11, 2019 22:00
@ciarmcom
Copy link
Member

@orenc17, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@cmonr cmonr requested review from a team February 12, 2019 00:01
cmonr
cmonr reviewed Feb 12, 2019
View reviewed changes
targets/targets.json
@@ -7992,6 +7992,7 @@
"MBEDTLS_ENTROPY_NV_SEED"
],
"deliver_to_target": "FUTURE_SEQUANA_PSA",
"delivery_dir": "TARGET_Cypress/TARGET_PSOC6_FUTURE/TARGET_FUTURE_SEQUANA_PSA/prebuilt",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@cmonr
Copy link
Contributor

cmonr commented Feb 12, 2019 •
edited
Loading

@0xc0170 Do these binaries need the usual readme and license additions next to them?
(If so, where is that nibble documented?)

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 12, 2019

@0xc0170 Do these binaries need the usual readme and license additions next to them?
(If so, where is that nibble documented?)

Yes they need, let me check the docs and fix it if not in there.

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 12, 2019

Section How to apply PBL correctly in licensing covers this

@lrusinowicz lrusinowicz mentioned this pull request Feb 12, 2019
Merged
@0xc0170
Copy link
Contributor

0xc0170 commented Feb 12, 2019

@lrusinowicz Please review

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 12, 2019

Ci started

bridadan
bridadan reviewed Feb 12, 2019
View reviewed changes
@mbed-ci
Copy link

mbed-ci commented Feb 12, 2019

Test run: FAILED

Summary: 3 of 8 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-ARM
  • jenkins-ci/mbed-os-ci_build-IAR
  • jenkins-ci/mbed-os-ci_build-GCC_ARM

@orenc17
Copy link
Contributor Author

orenc17 commented Feb 12, 2019

@ARMmbed/mbed-os-maintainers
Fixed according to @bridadan comments
please run CI and merge as soon as you can

@alekla01
Copy link
Contributor

Restarted CI after #9677

@mbed-ci
Copy link

mbed-ci commented Feb 12, 2019

Test run: FAILED

Summary: 3 of 8 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-GCC_ARM
  • jenkins-ci/mbed-os-ci_build-ARM
  • jenkins-ci/mbed-os-ci_build-IAR

@orenc17
Copy link
Contributor Author

orenc17 commented Feb 12, 2019

please run CI again. i didnt see any error in the logs
also the logs seems to run a version before the last commit

@cmonr
Copy link
Contributor

cmonr commented Feb 12, 2019

sigh, yup that in fact did happen. Good catch.

@cmonr
Copy link
Contributor

cmonr commented Feb 12, 2019

CI started

@cmonr
Copy link
Contributor

cmonr commented Feb 12, 2019

Gonna wait for #9678 (comment) to come in before this does.

@mbed-ci
Copy link

mbed-ci commented Feb 13, 2019

Test run: FAILED

Summary: 1 of 8 test jobs failed
Build number : 3
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-ARM

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 14, 2019

Ci restarted

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 14, 2019

New pushed after CI being started? Please let us know as we should cancel the current one if not yet done.

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 14, 2019

Is this now CI ready or not?

@mbed-ci
Copy link

mbed-ci commented Feb 14, 2019

Test run: FAILED

Summary: 3 of 12 test jobs failed
Build number : 4
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test
  • jenkins-ci/mbed-os-ci_dynamic-memory-usage
  • jenkins-ci/mbed-os-ci_exporter

@cmonr
Copy link
Contributor

cmonr commented Feb 14, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Feb 14, 2019

Test run: FAILED

Summary: 1 of 12 test jobs failed
Build number : 5
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test

@cmonr
Copy link
Contributor

cmonr commented Feb 15, 2019

New pushed after CI being started? Please let us know as we should cancel the current one if not yet done.

Holding CI restarts until the PR is ready...

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 19, 2019

Still waiting for #9708

@cmonr
Copy link
Contributor

cmonr commented Feb 22, 2019

@orenc17 #9708 is now merged!

Is a rebase needed, or should this now be good to enter CI?

@orenc17
Copy link
Contributor Author

orenc17 commented Feb 22, 2019

Rebased and ready for CI

@mbed-ci
Copy link

mbed-ci commented Feb 24, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 6
Build artifacts

@orenc17 orenc17 mentioned this pull request Feb 24, 2019
Merged
@0xc0170 0xc0170 merged commit 0d3fba8 into ARMmbed:master Feb 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr left review comments

@0xc0170 0xc0170 0xc0170 approved these changes

@bridadan bridadan bridadan approved these changes

@lrusinowicz lrusinowicz lrusinowicz approved these changes

Assignees
No one assigned
Labels
release-version: 5.12.0-rc1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@orenc17 @ciarmcom @cmonr @0xc0170 @mbed-ci @alekla01 @bridadan @lrusinowicz @NirSonnenschein