Greentea tests: set correct port to test against google.com #9686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeppoTakalo
approved these changes
Feb 12, 2019
|
@michalpasztamobica, thank you for your changes. |
|
@michalpasztamobica, thank you for your changes. |
cmonr
approved these changes
Feb 12, 2019
SeppoTakalo
approved these changes
Feb 13, 2019
0xc0170
approved these changes
Feb 13, 2019
|
CI started |
Test run: SUCCESSSummary: 10 of 10 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Port 2009 (discard port) is not available on google.com. For the purpose of the TLSSOCKET_HANDSHAKE_INVALID it is best to use the https port 443. This also makes the return value different (authorisation failure) and fulfills the original purpose of this test.
Pull request type
Reviewers
@SeppoTakalo