Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Greentea: Remove TLSSocket_simultaneous test #9730

Merged
merged 1 commit into from
Feb 19, 2019
Merged

Greentea: Remove TLSSocket_simultaneous test #9730

merged 1 commit into from
Feb 19, 2019

Conversation

michalpasztamobica
Copy link
Contributor

Description

The reason is that some platforms lack memory to run it. To be brought back once TLS library memory consumption is optimized.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[x] Test update
[ ] Breaking change

Reviewers

@SeppoTakalo
@VeijoPesonen
@mtomczykmobica
@KariHaapalehto
@tymoteuszblochmobica

Release Notes

SeppoTakalo
SeppoTakalo reviewed Feb 15, 2019
View reviewed changes
TESTS/netsocket/tls/main.cpp Outdated
@@ -196,7 +196,10 @@ Case cases[] = {
Case("TLSSOCKET_SEND_TIMEOUT", TLSSOCKET_SEND_TIMEOUT),
Case("TLSSOCKET_NO_CERT", TLSSOCKET_NO_CERT),
#ifndef __IAR_SYSTEMS_ICC__
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should remove the #ifndef __IAR as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. I removed it, but added a further warning comment, so someone doesn't spend hours debugging this test in case it gets uncommented in distant future.

@michalpasztamobica
Greentea: Remove TLSSocket_simultaneous test
a089661 
The reason is that some platforms lack memory to run it. To be brought
back once TLS library memory consumption is optimized.
@michalpasztamobica michalpasztamobica force-pushed the tlssocketsimultaneous_temporary_removal branch from 0f6f6f0 to a089661 Compare February 15, 2019 09:59
@ciarmcom
Copy link
Member

@michalpasztamobica, thank you for your changes.
@tymoteuszblochmobica @VeijoPesonen @SeppoTakalo @KariHaapalehto @mtomczykmobica @ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-test @ARMmbed/mbed-os-maintainers please review.

@michalpasztamobica
Copy link
Contributor Author

@0xc0170 , @cmonr , could we please get this PR merged in? I am getting more and more tickets from the nightly builds asking me to fix TLSSOCKET_SIMULTANEOUS test failures... :)

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 19, 2019

While we can get at least one more review, CI started

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 19, 2019 •
edited
Loading

The reason is that some platforms lack memory to run it. To be brought back once TLS library memory consumption is optimized.

As this is being skipped, is there tracking issue for reenabling this test case? Is not #8306 ?

@michalpasztamobica
Copy link
Contributor Author

@VeijoPesonen , @KariHaapalehto , @mtomczykmobica , @tymoteuszblochmobica , can we get at least one more code review here, please?

@0xc0170 , to track the IAR heap allocation fix there is an issue, that I am subscribed to.

@SeppoTakalo , you mentioned that TLS library memory allocation is being looked at - is there a ticket to track this?

@mbed-ci
Copy link

mbed-ci commented Feb 19, 2019

Test run: FAILED

Summary: 1 of 10 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_exporter

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 19, 2019

I see exporters were restarted, failure was in CI script

@michalpasztamobica
Copy link
Contributor Author

Yes, I restarted them after I saw the failure message. If we can get this in before the nightly build start, the results will get cleaner tomorrow.

@cmonr
Copy link
Contributor

cmonr commented Feb 19, 2019

CI job restarted: jenkins-ci/exporter

@cmonr cmonr merged commit 4cbcc36 into ARMmbed:master Feb 19, 2019
@cmonr
Copy link
Contributor

cmonr commented Feb 19, 2019

@KariHaapalehto @mtomczykmobica @tymoteuszblochmobica
Premature appologies since I brought this in without your reviews. @SeppoTakalo has already reviewed and it was requested to have this in for nightlies.

@jussisip
Copy link
Contributor

@0xc0170 , @cmonr , could we please get this PR merged in? I am getting more and more tickets from the nightly builds asking me to fix TLSSOCKET_SIMULTANEOUS test failures... :)

Test has been skipped now from nightly run, thnx.

@SeppoTakalo SeppoTakalo deleted the tlssocketsimultaneous_temporary_removal branch February 20, 2019 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

@SeppoTakalo SeppoTakalo SeppoTakalo approved these changes

@VeijoPesonen VeijoPesonen VeijoPesonen approved these changes

@KariHaapalehto KariHaapalehto Awaiting requested review from KariHaapalehto

@mtomczykmobica mtomczykmobica Awaiting requested review from mtomczykmobica

@tymoteuszblochmobica tymoteuszblochmobica Awaiting requested review from tymoteuszblochmobica

Assignees
No one assigned
Labels
release-version: 5.11.5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@michalpasztamobica @ciarmcom @0xc0170 @mbed-ci @cmonr @jussisip @SeppoTakalo @VeijoPesonen