Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto: Update to Mbed Crypto 1.0.0d5 and then to 1.0.0d6 #9795

Merged
merged 2 commits into from
Feb 26, 2019
Merged

crypto: Update to Mbed Crypto 1.0.0d5 and then to 1.0.0d6 #9795

merged 2 commits into from
Feb 26, 2019

Conversation

Patater
Copy link
Contributor

@Patater Patater commented Feb 21, 2019 •
edited
Loading

Description

Update Mbed Crypto to development snapshot 1.0.0d5. This brings backwards compatbility with previous PSA Crypto error codes for use by the PSA Compliance tests.

Depends on PR #9708 and will need a rebase atop it afterwards.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[X] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@ARMmbed/mbed-os-crypto, @avolinski

Release Notes

Previously, calls to psa_crypto_*_setup() would succeed even if a user did not initialize their operation context. Help users of the PSA Crypto API catch their own bugs by returning PSA_ERROR_BAD_STATE when a setup function is called with an uninitialized context.

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 21, 2019

Functionality change

Can you add Release notes section above ?

@Patater
Copy link
Contributor Author

Patater commented Feb 21, 2019

There is no functionality change between released versions of Mbed OS, only between Mbed Crypto as present in the yet unmerged #9708 and this PR. Do we still want release notes?

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 21, 2019

There is no functionality change between released versions of Mbed OS, only between Mbed Crypto as present in the yet unmerged #9708 and this PR. Do we still want release notes?

If 9708 captures it, then all fine.

@Patater
Copy link
Contributor Author

Patater commented Feb 21, 2019 •
edited
Loading

If both are merged, there is no functional change.

After updating this PR to include Mbed Crypto 1.0.0d6, there will indeed be a functional change.

@ciarmcom ciarmcom requested review from alekshex and a team February 21, 2019 16:00
@ciarmcom
Copy link
Member

@Patater, thank you for your changes.
@avolinski @ARMmbed/mbed-os-crypto @ARMmbed/mbed-os-maintainers please review.

@Patater
Copy link
Contributor Author

Patater commented Feb 21, 2019

Rebased to update to 1.0.0d6, which does actually have some functional changes. Will add release notes.

NirSonnenschein
NirSonnenschein reviewed Feb 21, 2019
View reviewed changes
features/mbedtls/mbed-crypto/importer/Makefile
@@ -29,7 +29,7 @@

# Set the Mbed Crypto release to import (this can/should be edited before
# import)
CRYPTO_RELEASE ?= mbedcrypto-1.0.0d2
CRYPTO_RELEASE ?= mbedcrypto-1.0.0d6
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you mean mbedcrypto-1.0.0d5 or mbedcrypto-1.0.0d6
as in the headline?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated headline to explain what we are doing now. Originally, this was just d5, now it is both d5 and then d6.

@orenc17 orenc17 mentioned this pull request Feb 21, 2019
Merged
@cmonr
Copy link
Contributor

cmonr commented Feb 22, 2019

@Patater Rebase when able!

#9708 is now in.

@Patater Patater changed the title crypto: Update to Mbed Crypto 1.0.0d5 crypto: Update to Mbed Crypto 1.0.0d5 and then to 1.0.0d6 Feb 22, 2019
@Patater
Copy link
Contributor Author

Patater commented Feb 22, 2019

Rebased atop latest master.

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 22, 2019 •
edited
Loading

@Patater As it's Friday, reviews are expected on Sunday due weekend? I'll schedule CI test run now

@mbed-ci
Copy link

mbed-ci commented Feb 22, 2019

Test run: FAILED

Summary: 1 of 8 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-ARM

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 22, 2019

Restarting CI (failure unrelated, and seems in the CI rather)

@mbed-ci
Copy link

mbed-ci commented Feb 22, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 2
Build artifacts

@Patater
Copy link
Contributor Author

Patater commented Feb 25, 2019

@dgreen-arm has approved on behalf of @ARMmbed/mbed-os-crypto

Awaiting review from @avolinski team

cmonr
cmonr approved these changes Feb 25, 2019
View reviewed changes
Copy link
Contributor

@cmonr cmonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit concerned about the PSA defines used since a lot of PSA activity is moving about, but I think it should be fine.

@cmonr
Copy link
Contributor

cmonr commented Feb 25, 2019

Awaiting review from @avolinski team

@cmonr cmonr added the risk: A label Feb 25, 2019
@Patater Patater mentioned this pull request Feb 26, 2019
Merged
@cmonr cmonr merged commit bf92043 into ARMmbed:master Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NirSonnenschein NirSonnenschein NirSonnenschein left review comments

@cmonr cmonr cmonr approved these changes

@alekshex alekshex alekshex approved these changes

@dgreen-arm dgreen-arm dgreen-arm approved these changes

Assignees
No one assigned
Labels
release-version: 5.12.0-rc1 risk: A
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Patater @0xc0170 @ciarmcom @cmonr @mbed-ci @NirSonnenschein @alekshex @dgreen-arm