Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide an option to disable writing developer certificate #9804

Merged
merged 3 commits into from
Feb 27, 2019
Merged

Provide an option to disable writing developer certificate #9804

merged 3 commits into from
Feb 27, 2019

Conversation

aashishc1988
Copy link
Contributor

@aashishc1988 aashishc1988 commented Feb 21, 2019 •
edited
Loading

Description

Addresses #8178

We have an option now "--disable-cert" for "mbed dm init" which disables writing developer certificate to mbed_cloud_dev_credentials.c

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Release Notes

It is possible now to disable writing developer certificate to mbed_cloud_dev_credentials using an option --no-developer-cert with "mbed dm init" command

@aashishc1988
Copy link
Contributor Author

@bridadan

@ciarmcom ciarmcom requested review from a team February 21, 2019 20:00
@ciarmcom
Copy link
Member

@aashishc1988, thank you for your changes.
@ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

@cmonr
Copy link
Contributor

cmonr commented Feb 21, 2019

Please update the PR description to follow the PR template.

@aashishc1988
Copy link
Contributor Author

Please update the PR description to follow the PR template.

Done

@cmonr
Copy link
Contributor

cmonr commented Feb 21, 2019

@aashishc1988 You also need to add a Release Notes section since this is a new feature.

theotherjimmy
theotherjimmy previously requested changes Feb 21, 2019
View reviewed changes
tools/device_management.py Outdated Show resolved Hide resolved
bridadan
bridadan reviewed Feb 21, 2019
View reviewed changes
tools/device_management.py Outdated Show resolved Hide resolved
tools/device_management.py Outdated Show resolved Hide resolved
@aashishc1988
Copy link
Contributor Author

@bridadan @theotherjimmy Ready for another review

bridadan
bridadan approved these changes Feb 22, 2019
View reviewed changes
Copy link
Contributor

@bridadan bridadan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good enough for me! Thanks for the changes, be sure to update the release notes section in your description with the new argument!

bridadan
bridadan reviewed Feb 22, 2019
View reviewed changes
tools/device_management.py Outdated
@@ -51,6 +51,9 @@ def __init__(self, *args, **kwargs):
"Create or transform a manifest. "
"Use {} [command] -h for help on each command."
).format(self.parser.prog)
subparserActionLength = len(self.parser._subparsers._actions)
initParser = self.parser._subparsers._actions[subparserActionLength-1].choices['init']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh we also talked offline about trying to filter based on the type of the subparser action instead of assuming it was at the end of the array, did you have any luck with that?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aashishc1988 ^^^

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw this but unfortunately I wouldnt get around this until later this week as we have some more pressing issues for 5.12 release. Lets keep this PR open, and I will fix this as soon as I can.

@bulislaw
Copy link
Member

This PR is at risk of missing 5.12 release as it's marked as "needs: review". Code freeze is coming! On Friday 1st. Please review the changes ASAP.

@theotherjimmy

@aashishc1988
Copy link
Contributor Author

@theotherjimmy I made some changes to stop assuming SubParser position in the list. Can you review the latest changes?

@cmonr
Copy link
Contributor

cmonr commented Feb 27, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Feb 27, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 27, 2019

cc @teetak01

@0xc0170 0xc0170 merged commit c123b98 into ARMmbed:master Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr left review comments

@bridadan bridadan bridadan approved these changes

@theotherjimmy theotherjimmy theotherjimmy approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-version: 5.12.0-rc1 risk: G
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@aashishc1988 @ciarmcom @cmonr @bulislaw @mbed-ci @0xc0170 @theotherjimmy @bridadan