-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cellular: CGACT not supported in coming firmware in BG96 #9837
Conversation
@jarvte, thank you for your changes. |
@jarvte Mind adding a |
Sure, done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All functions could return nsapi_error_t
?
AT clear error should be handled by caller and not deactivate_context
s?
* | ||
* @return true is any context is active, false otherwise or in case of error | ||
* @param number_of_active_contexts If given then in return contains the number of active contents | ||
* @param cid If given then active contents are checked only against this cid |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
contents -> contexts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
* @param number_of_active_contexts If given then in return contains the number of active contents | ||
* @param cid If given then active contents are checked only against this cid | ||
* | ||
* @return true is any (or the given cid) context is active, false otherwise or in case of error |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is -> if
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
bool active_found = false; | ||
int context_id; | ||
int active; | ||
// read active contexts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this "QIACT" part be overritten and rest of the code be in base class since it is so much and is copy pasted?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, fixed.
bool active_found = false; | ||
int context_id; | ||
int active; | ||
// read active contexts |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
af2e395
to
83c18fc
Compare
* same response. Can be overridden by the target class. | ||
* | ||
*/ | ||
virtual void set_context_command(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would get_context_state_command() be better name and comment:
"... Sends command to query the active state of the PDP contexts... Can be overridden by the target class."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jarvte ^^^
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed as suggested
This PR is at risk of missing 5.12 release as it's marked as "needs: work". Code freeze is coming! On Friday 1st. Please made necessary updates ASAP and make sure the reviewers are aligned for prompt code inspection. |
83c18fc
to
048335a
Compare
CI started |
Test run: FAILEDSummary: 1 of 1 test jobs failed Failed test jobs:
|
@jarvte Please take a look at the failed unit tests. |
048335a
to
4077898
Compare
Fixed. It was the last function name change... |
Can this be postponed to 5.12.1? We got high number of feature PR still opened for 5.12. |
From my point of view yes. I don't know about the person who wrote the issue #9749 |
Thanks ! It might still get in earlier but rather we focus on critical features/fixes now at this stage for 5.12.0 |
CI started |
Test run: SUCCESSSummary: 13 of 13 test jobs passed |
Description
Fix issue #9749
Fix is to use BG96 proprietary commands instead of CGACT.
API CellularNetwork::is_active_context changed but it takes default values so not marked as Breaking change.
Pull request type
Reviewers
@mirelachirica
Release Notes
Change API CellularNetwork::is_active_context to take more parameters to reduce copy-paste code.
API can be use in old way as parameters have default values.
Change CGACT to QIACT in case as BG96 module. Reason is that in upcoming firmware versions only QIACT is supported. Current firmware versions do support both commands.