BLE: Cordio host upgrade #9864

paul-szczepanek-arm · 2019-02-26T19:07:23Z

Description

Upgrade Cordio host to 19.02.
Open source Cordio controller.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[x] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@donatieng
@pan-

Release Notes

Upgrade of cordio host to new version (from 2.4 to 19.02). Should not impact users and be a in-place upgrade.
Replace compiled cordio controller libs with sources - no functional change and no impact on users.

paul-szczepanek-arm · 2019-02-26T19:07:53Z

Please add needs work. This is based on the pre-release and needs updating.

paul-szczepanek-arm · 2019-02-26T19:10:15Z

features/FEATURE_BLE/targets/TARGET_CORDIO/stack/ble-host/include/att_api.h

+
+/*************************************************************************************************/
+/*!
+ * \brief Attribute protocol client and server API. */


blame regex, will fix

no, really, eclipse regex did this, very unhappy with it now, will write a stern letter to the Eclipse Foundation

ciarmcom · 2019-02-26T20:00:36Z

@paul-szczepanek-arm, thank you for your changes.
@donatieng @pan- @ARMmbed/mbed-os-pan @ARMmbed/mbed-os-maintainers please review.

paul-szczepanek-arm · 2019-02-27T10:07:20Z

based on final 19.02 cordio release

donatieng

Thanks @paul-szczepanek-arm - a few minor things but looks good!

donatieng · 2019-02-27T11:02:04Z

features/FEATURE_BLE/targets/TARGET_CORDIO/source/CordioBLE.cpp

@@ -41,6 +41,10 @@
 /*! WSF handler ID */
 wsfHandlerId_t stack_handler_id;

+/* WSF heap allocation */
+uint8_t *SystemHeapStart;


Could these be made static? (and stack_handler_id above as well)

no, they need to be provided for wsf

features/FEATURE_BLE/targets/TARGET_CORDIO/stack/ble-host/include/att_defs.h

donatieng · 2019-02-27T11:05:45Z

features/FEATURE_BLE/targets/TARGET_CORDIO/stack_adaptation/pal_mbed_os_adaptation.cpp

+extern "C" {
+#endif
+
+/* UART */


Please remove these implementations if not needed :)

I can't, we need to provide something for the linker, I will signpost and comment them

paul-szczepanek-arm · 2019-02-27T13:47:53Z

ready for review, testing

0xc0170 · 2019-02-27T14:27:11Z

Upgrade of cordio host to new version. Should not impact users and be a in-place upgrade.

Can you be more specific - what version are we updating "from to" ?

paul-szczepanek-arm · 2019-02-27T14:35:35Z

Added versions but since numbering has clearly changed to year/month style, this is not that important.

0xc0170 · 2019-02-28T12:44:58Z

CI started

mbed-ci · 2019-02-28T17:06:57Z

Test run: FAILED

Summary: 1 of 9 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_build-IAR8

paul-szczepanek-arm · 2019-02-28T17:10:09Z

looks like CI problem

pan- · 2019-02-28T18:33:22Z

features/FEATURE_BLE/targets/TARGET_CORDIO/stack/ble-host/sources/stack/att/atts_sign.c

- /* verify signed write is permitted */
- if ((pAttr->settings & ATTS_SET_ALLOW_SIGNED) == 0)
+ /* verify permissions */
+ if (attsPermissions(pCcb->connId, ATTS_PERMIT_WRITE, handle, pAttr->permissions) != ATT_SUCCESS)


I remember we made changes here as the check from the stack were incorrect. We should double check if they are correct now

paul-szczepanek-arm · 2019-03-01T11:00:55Z

yes and yes

paul-szczepanek-arm · 2019-03-01T12:22:57Z

still testing but ready for CI

0xc0170 · 2019-03-01T12:33:26Z

@pan- Happy with it as it is?

paul-szczepanek-arm · 2019-03-01T12:54:09Z

he said yes

0xc0170 · 2019-03-01T13:03:23Z

he said yes

@pan- lost his voice? 😀

CI restarted

pan-

Lets get this in.

mbed-ci · 2019-03-01T14:33:21Z

Test run: FAILED

Summary: 1 of 9 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_build-IAR8

paul-szczepanek-arm · 2019-03-01T14:45:06Z

fixed IAR problem

paul-szczepanek-arm · 2019-03-01T14:51:05Z

IAR still complaining (different file), hang on

donatieng · 2019-03-01T14:59:40Z

@ARMmbed/mbed-os-maintainers sanity checking in progress: https://mbed-os.mbedcloudtesting.com/blue/organizations/jenkins/mbed-os-ci_fork-test/detail/mbed-os-ci_fork-test/125/pipeline/83

paul-szczepanek-arm · 2019-03-01T15:12:18Z

my IAR was out of date, fixed, ready for CI

adbridge · 2019-03-01T16:11:59Z

CI restarted

mbed-ci · 2019-03-01T18:51:36Z

Test run: FAILED

Summary: 2 of 14 test jobs failed
Build number : 3
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_tools-test
jenkins-ci/mbed-os-ci_greentea-test

donatieng · 2019-03-01T19:36:51Z

Hmmm... Looks like a K66F filesystem test being flaky 😿

cmonr · 2019-03-01T23:07:57Z

@donatieng Fortunately, we can restart just jenkins-ci/greentea-test.

It's been restarted.

paul-szczepanek-arm commented Feb 26, 2019

View reviewed changes

ciarmcom requested review from donatieng, pan- and a team February 26, 2019 20:00

ciarmcom added the needs: review label Feb 26, 2019

cmonr added needs: work and removed needs: review labels Feb 27, 2019

paul-szczepanek-arm force-pushed the cordio-host-upgrade branch from 252268a to 48d2a7c Compare February 27, 2019 10:06

0xc0170 added the release-version: 5.12.0-rc1 label Feb 27, 2019

donatieng suggested changes Feb 27, 2019

View reviewed changes

0xc0170 added the risk: A label Feb 27, 2019

0xc0170 added needs: review and removed needs: work labels Feb 27, 2019

0xc0170 approved these changes Feb 27, 2019

View reviewed changes

donatieng approved these changes Feb 27, 2019

View reviewed changes

0xc0170 added needs: CI and removed needs: review labels Feb 28, 2019

paul-szczepanek-arm force-pushed the cordio-host-upgrade branch from a6753c9 to b0870a9 Compare February 28, 2019 17:34

donatieng approved these changes Feb 28, 2019

View reviewed changes

pan- reviewed Feb 28, 2019

View reviewed changes

remove duplicate headers

0c85578

paul-szczepanek-arm force-pushed the cordio-host-upgrade branch from 094dced to cf8934e Compare March 1, 2019 11:00

reinstate fixes

e247852

paul-szczepanek-arm force-pushed the cordio-host-upgrade branch from 3e31495 to e247852 Compare March 1, 2019 11:23

fix signing permissions

34ef173

0xc0170 added needs: review and removed needs: work labels Mar 1, 2019

0xc0170 added needs: CI and removed needs: review labels Mar 1, 2019

pan- approved these changes Mar 1, 2019

View reviewed changes

remove define that trips up IAR

f740985

paul-szczepanek-arm force-pushed the cordio-host-upgrade branch from 8d97ceb to f740985 Compare March 1, 2019 14:46

MBED_WEAK in random spot removed

61b0631

ghost added the PM_ACCEPTED label Mar 1, 2019

cmonr merged commit 4043623 into ARMmbed:master Mar 2, 2019

cmonr removed the needs: CI label Mar 2, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

BLE: Cordio host upgrade #9864

BLE: Cordio host upgrade #9864

paul-szczepanek-arm commented Feb 26, 2019 •

edited

Loading

paul-szczepanek-arm commented Feb 26, 2019

paul-szczepanek-arm Feb 26, 2019

paul-szczepanek-arm Feb 27, 2019

ciarmcom commented Feb 26, 2019

paul-szczepanek-arm commented Feb 27, 2019

donatieng left a comment

donatieng Feb 27, 2019

paul-szczepanek-arm Feb 27, 2019

donatieng Feb 27, 2019

paul-szczepanek-arm Feb 27, 2019

paul-szczepanek-arm commented Feb 27, 2019

0xc0170 commented Feb 27, 2019

paul-szczepanek-arm commented Feb 27, 2019

0xc0170 commented Feb 28, 2019

mbed-ci commented Feb 28, 2019

paul-szczepanek-arm commented Feb 28, 2019

pan- Feb 28, 2019

paul-szczepanek-arm commented Mar 1, 2019

paul-szczepanek-arm commented Mar 1, 2019

0xc0170 commented Mar 1, 2019

paul-szczepanek-arm commented Mar 1, 2019

0xc0170 commented Mar 1, 2019

pan- left a comment

mbed-ci commented Mar 1, 2019

paul-szczepanek-arm commented Mar 1, 2019

paul-szczepanek-arm commented Mar 1, 2019 •

edited

Loading

donatieng commented Mar 1, 2019

paul-szczepanek-arm commented Mar 1, 2019

adbridge commented Mar 1, 2019

mbed-ci commented Mar 1, 2019

donatieng commented Mar 1, 2019 •

edited

Loading

cmonr commented Mar 1, 2019

BLE: Cordio host upgrade #9864

BLE: Cordio host upgrade #9864

Conversation

paul-szczepanek-arm commented Feb 26, 2019 • edited Loading

Description

Pull request type

Reviewers

Release Notes

paul-szczepanek-arm commented Feb 26, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ciarmcom commented Feb 26, 2019

paul-szczepanek-arm commented Feb 27, 2019

donatieng left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

paul-szczepanek-arm commented Feb 27, 2019

0xc0170 commented Feb 27, 2019

paul-szczepanek-arm commented Feb 27, 2019

0xc0170 commented Feb 28, 2019

mbed-ci commented Feb 28, 2019

paul-szczepanek-arm commented Feb 28, 2019

Choose a reason for hiding this comment

paul-szczepanek-arm commented Mar 1, 2019

paul-szczepanek-arm commented Mar 1, 2019

0xc0170 commented Mar 1, 2019

paul-szczepanek-arm commented Mar 1, 2019

0xc0170 commented Mar 1, 2019

pan- left a comment

Choose a reason for hiding this comment

mbed-ci commented Mar 1, 2019

paul-szczepanek-arm commented Mar 1, 2019

paul-szczepanek-arm commented Mar 1, 2019 • edited Loading

donatieng commented Mar 1, 2019

paul-szczepanek-arm commented Mar 1, 2019

adbridge commented Mar 1, 2019

mbed-ci commented Mar 1, 2019

donatieng commented Mar 1, 2019 • edited Loading

cmonr commented Mar 1, 2019

paul-szczepanek-arm commented Feb 26, 2019 •

edited

Loading

paul-szczepanek-arm commented Mar 1, 2019 •

edited

Loading

donatieng commented Mar 1, 2019 •

edited

Loading