Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build version output to programs/ssl ssl_client2/ssl_server2 #5443

Closed
boaks opened this issue Jan 20, 2022 · 6 comments · Fixed by #6580
Closed

Add build version output to programs/ssl ssl_client2/ssl_server2 #5443

boaks opened this issue Jan 20, 2022 · 6 comments · Fixed by #6580
Assignees
Labels
enhancement good-first-issue Good for newcomers help-wanted This issue is not being actively worked on, but PRs welcome. size-s Estimated task size: small (~2d)

Comments

@boaks
Copy link

boaks commented Jan 20, 2022

Suggested enhancement

Please generally add the build version to the output of ssl_client2 and ssl_server2.
Maybe additionally, if "build-version=1" is given, prints the build version only an stop.

Justification

I would like to use these both binaries to ensure DTLS interoperability with Eclipse/Californium (see my pending PR 1882 there).
Using the build version makes it much easier to adapt such interoperability test according the usable functions of each build version. It also helps in case of reported issues to know the build version.

@paul-elliott-arm paul-elliott-arm added Community enhancement help-wanted This issue is not being actively worked on, but PRs welcome. size-s Estimated task size: small (~2d) labels Jan 20, 2022
@paul-elliott-arm
Copy link
Member

Hi!

I am unsure what the priority of this would be for the team, but in the meantime, I invite you to submit a PR implementing this, as this would be the quickest way of achieving this.

Also, I am sure you are aware but as yet, we do not support DTLS1.3, however this is on the roadmap for the near future.

@boaks
Copy link
Author

boaks commented Jan 20, 2022

I am unsure what the priority of this would be for the team, but in the meantime, I invite you to submit a PR implementing this, as this would be the quickest way of achieving this.

Thanks for your answer! It's no problem, if it takes longer.

(For me it requires the permission for contribution of my employer, that would take even longer :-). Time I better spend in Eclipse/Californium).

Also, I am sure you are aware but as yet, we do not support DTLS1.3, however this is on the roadmap for the near future.

For Eclipse/Californium it was frequently requested, but not that frequently.
For now, I don't see, that the current committer team of Eclipse/Californium will be able to provide a implementation in a near future. So we will see, how long it takes ;-).

@paul-elliott-arm
Copy link
Member

An extra thought I had - if you are compiling the executables (which I presume you are), then its possible you could work around by parsing version.h to find the given version, in the mean time.

@paul-elliott-arm paul-elliott-arm removed their assignment Jan 26, 2022
@boaks
Copy link
Author

boaks commented Jan 26, 2022

if you are compiling the executables

Sure, and I know the version. So, I personally don't need to read that version from the output.
In fact I'm using PR #5061 in order to test the compatibility according (upcoming) RFC9146, with that, my version will be anyway a wrong one.
I also don't know, If someone else will really try to use the Eclipse/Californium - Interoperability Tests to ensure, that a special use-case/parameter-set or a future update is working. Therefore, it's not that urgent.

But in the end, I think, it will be also valuable for mbedTLS, if that version is printed.

(Sometimes I'm not sure, why adding four lines to a demo takes in some projects longer discussions than it would take to add them. At least for the project I work for, I also like, if someone contributes something. Bur for the very small stuff, it's also OK for me to add that by myself. )

@yanrayw
Copy link

yanrayw commented Oct 17, 2022

Hi

Suggested enhancement

Please generally add the build version to the output of ssl_client2 and ssl_server2. Maybe additionally, if "build-version=1" is given, prints the build version only an stop.

Regarding this enhancement, I have submitted a PR to implement it. The build version could be printed out in ssl_client2. However, I'm not very clear where it should be. Any advice? Please check #6436 for more output information.

@xkqian
Copy link
Contributor

xkqian commented Nov 15, 2022

The related PRs #6580 and #6436 has been merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement good-first-issue Good for newcomers help-wanted This issue is not being actively worked on, but PRs welcome. size-s Estimated task size: small (~2d)
Projects
None yet
7 participants