Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add build version to the output of ssl_client2 #6433

Closed
wants to merge 0 commits into from
Closed

Add build version to the output of ssl_client2 #6433

wants to merge 0 commits into from

Conversation

yanrayw
Copy link

@yanrayw yanrayw commented Oct 17, 2022

Description

Resolves: #5443

Status

READY for review

Additional comments

This PR adds the support to print build version in ssl_client2 as following:

  . Verifying peer X.509 certificate... ok
  . Peer certificate information    ...
build version     : 50462976
cert. version     : 3
serial number     : 02

Besides, if we give "build_version=1", only build version info will be printed out.

$ ./ssl_client2 build_version=1
build version: 50462976

@yanrayw yanrayw added enhancement needs-review Every commit must be reviewed by at least two team members, needs-ci Needs to pass CI tests needs-reviewer This PR needs someone to pick it up for review size-s Estimated task size: small (~2d) priority-medium Medium priority - this can be reviewed as time permits labels Oct 17, 2022
@xkqian
Copy link
Contributor

xkqian commented Oct 17, 2022

Create one new branch in your repo other than development(master branch) is better.
Maybe you will work on different PRs, a meaningfull branch name is better.

@yanrayw yanrayw closed this Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuhaoth yuhaoth Awaiting requested review from yuhaoth

@xkqian xkqian Awaiting requested review from xkqian

Assignees
No one assigned
Labels
enhancement needs-ci Needs to pass CI tests needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review priority-medium Medium priority - this can be reviewed as time permits size-s Estimated task size: small (~2d)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add build version output to programs/ssl ssl_client2/ssl_server2
2 participants
@yanrayw @xkqian