Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IOTIDE 2166: hg branches #29

Merged
merged 3 commits into from
Nov 11, 2019
Merged

IOTIDE 2166: hg branches #29

merged 3 commits into from
Nov 11, 2019

Conversation

federicobozzini
Copy link

@federicobozzini federicobozzini commented Nov 6, 2019 •
edited
Loading

Changes

List the changes this PR introduces

  • improvement on branch management when using mercurial
  • the current branch is now shown in the status bar
  • the commit history is update when switiching to a different branch
  • the correct branches are shown in the branch selector

@federicobozzini federicobozzini marked this pull request as ready for review November 11, 2019 13:23
mcgordonite
mcgordonite approved these changes Nov 11, 2019
View reviewed changes
Copy link

@mcgordonite mcgordonite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works much better! Still need to implement the new branch function.

packages/hg/src/common/hg.ts
*/
branch(repository: Repository, options: { type: 'local' | 'remote' | 'all' }): Promise<Branch[]>;
branches(repository: Repository): Promise<Branch[]>;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is much clearer 👍

@federicobozzini federicobozzini merged commit 67045e8 into release-0.9.0 Nov 11, 2019
@federicobozzini federicobozzini deleted the 2166-hg-branches branch November 11, 2019 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcgordonite mcgordonite mcgordonite approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@federicobozzini @mcgordonite