Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track upstream branch in update examples #231

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Track upstream branch in update examples #231

merged 1 commit into from
Jan 17, 2025

Conversation

jhkennedy
Copy link
Contributor

@jhkennedy jhkennedy commented Jan 17, 2025

The update examples action fails because gh pr doesn't know which remote branch to use. Simply tracking the upstream branch when we push the proposed changes is sufficient for gh pr, or, we could explicitly set --head origin/BRANCH_NAME. I prefer the former.

You can see a successful run of the Update Examples action in #233 which was created from this PR (908563c, specifically).

fixes #229

This allows the `gh` CLI to know which remote branch to use for PRs
@jhkennedy jhkennedy changed the title Update-examples play Track upstream branch in update example Jan 17, 2025
@jhkennedy jhkennedy changed the title Track upstream branch in update example Track upstream branch in update examples Jan 17, 2025
@jhkennedy jhkennedy marked this pull request as ready for review January 17, 2025 22:16
@jhkennedy jhkennedy requested a review from a team January 17, 2025 22:16
@jtherrmann jtherrmann added the bumpless Changes to documentation, CI/CD pipelines, etc that don't affect the project's version label Jan 17, 2025
@jhkennedy jhkennedy merged commit 259b15b into develop Jan 17, 2025
7 of 9 checks passed
@jhkennedy jhkennedy deleted the gh-cli-debug branch January 17, 2025 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bumpless Changes to documentation, CI/CD pipelines, etc that don't affect the project's version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Actions Examples workflow fails on "Open PR" step
2 participants