Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automated action on update-profiles-csv.yml failing due to main branch protection #292

Open
timmwille opened this issue Feb 28, 2023 · 6 comments
Assignees
Labels
bug Something isn't working prio1 first priority

Comments

@timmwille
Copy link
Member

timmwille commented Feb 28, 2023

 run extract.py
Node.js 12 actions are deprecated. Please update the following actions to use Node.js 16: actions/checkout@v2, actions/setup-python@v2. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.

Fix in the actions related to:
https://github.com/ASKnetCommunity/LEAD/blob/main/.github/workflows/update-profiles-csv.yml

@timmwille timmwille added bug Something isn't working prio1 first priority labels Feb 28, 2023
@timmwille timmwille self-assigned this Feb 28, 2023
@timmwille
Copy link
Member Author

@timmwille
Copy link
Member Author

@dutkulang @chardso we've got technicians work to do maybe @MartinSchott can help ;)

@chardso
Copy link
Contributor

chardso commented Feb 28, 2023

Great 👍

@timmwille
Copy link
Member Author

not fixed yet

@timmwille timmwille reopened this Feb 28, 2023
@timmwille
Copy link
Member Author

Ok looks like the main problem is caused by the main branch protection → probably the solution is to trigger the action in another branch? or manually only and then do the merge in main? @MartinSchott @hoijui I'm not sure what is the best solution in this case?

timmwille added a commit that referenced this issue Feb 28, 2023
updated profiles.csv manually (through GitHub Action) tmp fix for #292
@timmwille timmwille changed the title automated action on update-profiles-csv.yml failing due to Node.js deprecated automated action on update-profiles-csv.yml failing due to main branch protection Feb 28, 2023
@hoijui
Copy link
Contributor

hoijui commented Mar 1, 2023

This is only a warning, which you can ignore for now:

Node.js 12 actions are deprecated

This is the real issue (as you already found out):

error: failed to push some refs to 'https://github.com/ASKnetCommunity/LEAD'
hint: Updates were rejected because the tip of your current branch is behind
hint: its remote counterpart. Integrate the remote changes (e.g.
hint: 'git pull ...') before pushing again.
hint: See the 'Note about fast-forwards' in 'git push --help' for details.

... ouh boy, what did the children do when I left town for a night and day?!

Whenever you commit to main, you run a script that generates a file, and commits and pushes it to main ...

-> bad idea!
don't do that!

It is a generated file, so should not be in the repo. put it on your pages instead, and fetch it from there if needed, or generate it on the fly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working prio1 first priority
Projects
None yet
Development

No branches or pull requests

3 participants