Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for hostname validation feature. #53

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mrigaya
Copy link

@mrigaya mrigaya commented Jun 7, 2018

As per openssl wiki page https://wiki.openssl.org/index.php/Hostname_validation, openssl version prior to 1.0.2 doesn't perform hostname validation. So nopoll users should handle the hostname validation part during connection handshake at the client end.

This code can help users to enable/disable hostname validation feature based on the options they are providing during the TLS connect. As we could see in the computer security this man in the middle attack is most common security threats faced by the current world, So it is better to enable hostname validation by default and we did the same here. And also user may not be aware of this hostname validation is not handled in their openssl in case if they are using the openssl version < 1.0.2.

Review these changes and Please let me know if it requires any modification/suggestion from your end.

@mrigaya
Copy link
Author

mrigaya commented Jun 19, 2018

@francisbrosnan any suggestion on this pull request?

@francisbrosnan
Copy link
Member

Hello @mrigaya
CLA is still pending. Best Regards.

@kristakhare
Copy link

The CLA should be covered now, per Jorge. Please let us know otherwise.

@selvamKrish
Copy link

@francisbrosnan Thanks for your time and considerations, please let us know if there is any update/suggestion on this PR.

@francisbrosnan
Copy link
Member

Hello @selvamKrish, just acknoledge your message. We didn't have time to review this. We'll keep you updated as soon as possible. Best Regards.

@schmidtw
Copy link
Contributor

@francisbrosnan have you had any cycles to look at this code?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants