Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI on macos-latest and Python 3.10 and 3.11 is failing all the time #822

Closed
otizonaizit opened this issue Sep 27, 2024 · 6 comments
Closed

Comments

@otizonaizit
Copy link
Member

All CI jobs fail on Python 3.10 and 3.11 when run with macos-latest.

I think this problem is not related to pelita but to the CI setup on GitHub or some macos-latest issues.
I suggest to remove these two combinations from the test matrix, or we can't rely on CI for the time being...

@Debilski
Copy link
Member

Closing. The tests fail because you should fix them. ;)

@otizonaizit
Copy link
Member Author

well, no. Look at the jobs failing here:
#821
This is what I was referring to.

@otizonaizit otizonaizit reopened this Sep 27, 2024
@Debilski
Copy link
Member

Seems to be exactly the test that you touched. The other jobs don’t even run (and fail) because this one failed.

FAILED test/test_filter_gamestates.py::test_pacman_resets_age - assert [{}, {}] == [{(8, 2): 1}, {}]

@Debilski
Copy link
Member

To put it differently: Did you run pytest locally before pushing?

@otizonaizit
Copy link
Member Author

sorry, mea culpa. I got confused because I am seeing failing macos tests in another project and I simply assumed this is happening here. And got even more confused when github decides to stop other jobs if one fails.
Anyway, fixed now.

@Debilski
Copy link
Member

It is not impossible of course. We do depend on macos-latest and there has been a new macOS release …

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants