DepClean Gradle Plugin implementation. #93

ABHAY0O7 · 2021-06-03T17:49:50Z

Currently, I think I have implemented the core logic correctly, but still, there are some drawbacks that I am still trying to improve.
Also, the code that I have written until now is very unmanaged, there are lots of unnecessary commented out code, there are lots of method that I used for debugging and I provided very few java docs, so sorry for that. Please ignore these parts of code.
Currently to test the plugin,

First, Run gradle clean build without changing anything,
Run gradle publishToMavenLocal
Now uncomment the buildscript and apply plugin part that I have commented in build.gradle and again run gradle clean build
Run gradle copyDependenciesLocally task.
Run final gradle debloat task and you can see the results.

Thank you

…ware/depclean

ABHAY0O7 · 2021-06-03T18:21:49Z

Hello @tdurieux @bbaudry
I was thinking that if we could have a meet this weekend or may after that so that I can discuss the current status of the plugin, and also some problems that I am facing right now. The problems are quite complicated which I think can only be illustrated better at a meet, so it will be better for me.

tdurieux

Could you remove all the Gradle folders, we would like to avoid to have .ar files inside the project?

Could you remove all the .gradle folder from the test resources?

Could you rename the folder depclean-gradle-plugin/src/Test to test?

It is for the moment difficult to review the changes when so many files are included in the PR. After you remove the folders I will continue to review the PR

ABHAY0O7 · 2021-06-17T19:59:38Z

Could you remove all the .gradle folder from the test resources?

I already removed them but I forgot to remove their caches, but now I removed them too.

Could you rename the folder depclean-gradle-plugin/src/Test to test?

Renamed 👍🏽

Could you remove all the Gradle folders, we would like to avoid to have .ar files inside the project?

Are you talking about gradle.wrapper folders? If no, then please can you be more specific but If yes then in my knowledge we should not involve these folders in .gitignore as they are important ones. But if you want these folders to be ignored for now then I can remove them too. So please can you be more specific about this question that what I have to do.

tdurieux

Good job, the PR seems good. There are few elements that need to improve but it should be relatively fast.

depclean-gradle-plugin/src/main/java/se/kth/depclean/depcleanGradleAction.java

depclean-gradle-plugin/build.gradle

depclean-gradle-plugin/gradle/wrapper/gradle-wrapper.properties

depclean-gradle-plugin/src/main/java/se/kth/depclean/DepCleanGradleTask.java

...an-gradle-plugin/src/main/java/se/kth/depclean/analysis/GradleProjectDependencyAnalysis.java

...dle-plugin/src/test/resources/all_dependencies_used/gradle/wrapper/gradle-wrapper.properties

depclean-gradle-plugin/src/main/java/se/kth/depclean/DepCleanGradleAction.java

tdurieux · 2021-07-05T15:37:50Z

...le-plugin/src/main/java/se/kth/depclean/analysis/DefaultGradleProjectDependencyAnalyzer.java

+  /**
+   * If true, the project's classes in target/test-classes are not going to be analyzed.
+   */
+  private final boolean isIgnoredTest;


Could you create the same parameters that we have in the maven plugins? (could be done in a separate PR)

I added all the parameters that we have in the maven plugin except for 3 parameters about which I talked about here
Please take a look there and then reply accordingly.

I would still implement those parameters, we can have set the default to false for those additional parameters but those are useful.

…leAction

ABHAY0O7 · 2021-07-07T09:08:22Z

Hello @tdurieux
I have implemented all the requested changes except for one which is still unresolved.
To resolve them, you have to be more clear that what I have to do.

Thank you.

depclean-gradle-plugin/src/main/java/se/kth/depclean/DepCleanGradleAction.java

...le-plugin/src/main/java/se/kth/depclean/analysis/DefaultGradleProjectDependencyAnalyzer.java

tdurieux · 2021-07-19T17:29:00Z

Looks good. depclean-gradle-plugin/src/main/java/se/kth/depclean/DepCleanGradleAction.java is really big maybe we should work on a way to make it smaller and easier to maintain.

…ties classes for Action class

ABHAY0O7 · 2021-07-21T09:50:08Z

Looks good. depclean-gradle-plugin/src/main/java/se/kth/depclean/DepCleanGradleAction.java is really big maybe we should work on a way to make it smaller and easier to maintain.

Hii @tdurieux,
As you suggested I reduced the size of the DepCleanGradleAction, to do this I introduce two new utility classes.
I also used the Path object instead of String path which saves a little bit extra lines of code.

tdurieux · 2021-07-21T10:27:08Z

I just realized that Github Action does not execute the test from the gradle plugin. Could you update https://github.com/castor-software/depclean/blob/master/.github/workflows/build.yml to include the gradle plugin tests.
I think it is the final task before I can merge the PR.

It is a good job, continue like this!

…were not building automatically, resulting failure of tests)

sonarqubecloud · 2021-07-26T17:44:15Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

ABHAY0O7 · 2021-07-26T22:35:29Z

Hii @tdurieux
I want you to please don't merge this PR for now.
This is PR is very messy and there are some useless commits also, so to make the history very clean and easily understandable, give me some time, I will update you soon.

Thank you

ABHAY0O7 · 2021-07-27T09:30:32Z

Hii @tdurieux
I have started to make the git history clean and understandable.
I have opened some PR's with their order of merge in their titles, now the commits are more clear and understandable with some description.
I want you to review and merge the PRs as soon as possible, so that when I push new commits to my branches then they should be on new PR. :))

Thank you
Abhay

ABHAY0O7 · 2021-07-28T14:35:37Z

Hii @tdurieux
Nice to see you :))
I will update you with remaining PRs up to 7 PM GMT.

Thank you

ABHAY0O7 · 2021-07-29T08:04:59Z

The work of this PR is divided and implemented int these PRs :

ABHAY0O7 added 16 commits April 21, 2021 13:43

Updated readme

94b98d4

Update master Merge branch 'master' of https://github.com/castor-soft…

38571f5

…ware/depclean

Completed task : Analysis of gradle dependencies

e941c23

Added Gradle plugin module on master branch

f81be37

Receiving depClean core Jar

edda360

Completed core logic

9a51603

Updated .gitignore

4ef552e

Modified gitignore

1145d15

Again updated gitignore

18d3c48

Implemented the core ligic correctly but still plugin has some drawbacks

70d278b

Updated checksum.logs

53715e2

Fix merge conflicts

fa1bca5

Deleted cache

73e385e

Added gitignore for gradle module

0462616

Added buildDir to gitignore

6d36bd1

Commented some code for testing purpose

fc823b5

ABHAY0O7 mentioned this pull request Jun 3, 2021

Gradle plugin demonstration #89

Closed

ABHAY0O7 added 2 commits June 3, 2021 23:36

Removed unnecessary test resources for now

341413d

Removed cache for test resources

41e7dea

ABHAY0O7 added 3 commits June 8, 2021 23:24

Plugin is almost complete from here we can start testing

a625461

Added test for empty project

d09d907

Make it compatible for testing

23451ab

ABHAY0O7 mentioned this pull request Jun 9, 2021

Testing the gradle plugin #92

Closed

Added tests and removed dependency of project on copy dependencies task

50f3fcf

tdurieux suggested changes Jun 17, 2021

View reviewed changes

Removed caches for test resources

c0dbaf0

Added extra configuration to the plugin to make it highly flexible

75b9f3d

ABHAY0O7 changed the title ~~Gradle Plugin core implemented.~~ DepClean Gradle Plugin implementation. Jul 4, 2021

ABHAY0O7 requested a review from tdurieux July 4, 2021 11:08

tdurieux suggested changes Jul 5, 2021

View reviewed changes

Added two new extensions and perform some refactoring on DepCleanGrad…

0764c7b

…leAction

ABHAY0O7 added 6 commits July 8, 2021 05:07

Added package-info files and refactored DepCleanGradlePlugin.class

2206790

Refactored extension and task class

3dc8694

Refactored DepCleanGradleAction.class

3b15bab

Refactored GradleProjectDependencyAnalysis.class

1c526df

Refactored DefaultGradleProjectDependencyAnalyzer.class

d7f9979

Implemented createBuildDebloated parameter with functional test

2138358

ABHAY0O7 requested a review from tdurieux July 18, 2021 00:51

tdurieux reviewed Jul 19, 2021

View reviewed changes

depclean-gradle-plugin/src/main/java/se/kth/depclean/DepCleanGradleAction.java Outdated Show resolved Hide resolved

tdurieux reviewed Jul 19, 2021

View reviewed changes

...le-plugin/src/main/java/se/kth/depclean/analysis/DefaultGradleProjectDependencyAnalyzer.java Outdated Show resolved Hide resolved

Decrease the size of DepCleanGradleAction and introduce two new utili…

35b2606

…ties classes for Action class

ABHAY0O7 added 2 commits July 26, 2021 08:56

Refactored tests and removed the bug (Previously, resources projects …

6ab6de9

…were not building automatically, resulting failure of tests)

Added gradle build (not test) to CI

29e6f7d

ABHAY0O7 force-pushed the My_Gradle branch from 4e3573e to 29e6f7d Compare July 26, 2021 17:41

ABHAY0O7 changed the title ~~DepClean Gradle Plugin implementation.~~ DepClean Gradle Plugin implementation. (Not for merge) Jul 27, 2021

ABHAY0O7 closed this Jul 29, 2021

ABHAY0O7 deleted the My_Gradle branch August 12, 2021 18:51

ABHAY0O7 changed the title ~~DepClean Gradle Plugin implementation. (Not for merge)~~ DepClean Gradle Plugin implementation. Aug 20, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DepClean Gradle Plugin implementation. #93

DepClean Gradle Plugin implementation. #93

ABHAY0O7 commented Jun 3, 2021 •

edited

Loading

ABHAY0O7 commented Jun 3, 2021

tdurieux left a comment

ABHAY0O7 commented Jun 17, 2021

tdurieux left a comment

tdurieux Jul 5, 2021

ABHAY0O7 Jul 7, 2021

tdurieux Jul 9, 2021

ABHAY0O7 commented Jul 7, 2021 •

edited

Loading

tdurieux commented Jul 19, 2021

ABHAY0O7 commented Jul 21, 2021

tdurieux commented Jul 21, 2021

sonarqubecloud bot commented Jul 26, 2021

ABHAY0O7 commented Jul 26, 2021

ABHAY0O7 commented Jul 27, 2021

ABHAY0O7 commented Jul 28, 2021

ABHAY0O7 commented Jul 29, 2021

DepClean Gradle Plugin implementation. #93

DepClean Gradle Plugin implementation. #93

Conversation

ABHAY0O7 commented Jun 3, 2021 • edited Loading

ABHAY0O7 commented Jun 3, 2021

tdurieux left a comment

Choose a reason for hiding this comment

ABHAY0O7 commented Jun 17, 2021

tdurieux left a comment

Choose a reason for hiding this comment

tdurieux Jul 5, 2021

Choose a reason for hiding this comment

ABHAY0O7 Jul 7, 2021

Choose a reason for hiding this comment

tdurieux Jul 9, 2021

Choose a reason for hiding this comment

ABHAY0O7 commented Jul 7, 2021 • edited Loading

tdurieux commented Jul 19, 2021

ABHAY0O7 commented Jul 21, 2021

tdurieux commented Jul 21, 2021

sonarqubecloud bot commented Jul 26, 2021

ABHAY0O7 commented Jul 26, 2021

ABHAY0O7 commented Jul 27, 2021

ABHAY0O7 commented Jul 28, 2021

ABHAY0O7 commented Jul 29, 2021

ABHAY0O7 commented Jun 3, 2021 •

edited

Loading

ABHAY0O7 commented Jul 7, 2021 •

edited

Loading