Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sorald always indents added elements with tabs #256

Closed
slarse opened this issue Dec 1, 2020 · 7 comments · Fixed by #272
Closed

Sorald always indents added elements with tabs #256

slarse opened this issue Dec 1, 2020 · 7 comments · Fixed by #272
Labels
bug Something isn't working
Milestone
Week 50

Comments

@slarse
Copy link
Collaborator

slarse commented Dec 1, 2020

New elements are printed with tabs for some reason.
@slarse slarse added the bug Something isn't working label Dec 1, 2020
@slarse
Copy link
Collaborator Author

slarse commented Dec 1, 2020

This appears to be a sniper printer problem

@slarse
Copy link
Collaborator Author

slarse commented Dec 1, 2020

See INRIA/spoon#3715

@slarse slarse mentioned this issue Dec 1, 2020
Closed
@slarse slarse changed the title Sorald always prints added elements with tabs Sorald always indents added elements with tabs Dec 2, 2020
@slarse slarse added this to the Week 50 milestone Dec 2, 2020
@slarse slarse mentioned this issue Dec 7, 2020
Merged
@slarse
Copy link
Collaborator Author

slarse commented Dec 7, 2020

Moving this to week 51's sprint as I messed up on a corner case of the indentation detection, so we must wait for the next beta release of Spoon :(

@slarse slarse modified the milestones: Week 50, Week 51 Dec 7, 2020
@monperrus
Copy link
Contributor

monperrus commented Dec 7, 2020 via email

@monperrus
Copy link
Contributor

monperrus commented Dec 7, 2020 via email

@slarse
Copy link
Collaborator Author

slarse commented Dec 8, 2020

beta-7 contains a bug in the indentation detection, that I'm fixing with INRIA/spoon#3722. That can probably be merged as soon as we get CI up and running.

@slarse slarse modified the milestones: Week 51, Week 50 Dec 9, 2020
@slarse
Copy link
Collaborator Author

slarse commented Dec 9, 2020

@monperrus Snapshot worked, #272 is passing tests. I suggest we simply depend on the Spoon snapshot for now as I'm fairly often fiddling about in Spoon. We don't really need a stable version of Spoon until we make a release of Sorald.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Milestone
Week 50
Development

Successfully merging a pull request may close this issue.

fix: Use Spoon snapshot to fix incorrect indentation style slarse/sorald
2 participants
@monperrus @slarse