review: fix(sniper): Fix rounding error in indentation detection on single type member #3722
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a rather silly rounding error in the indentation detection: if there's a single type member,
usesTabs = 1 / 2 = 0
. Therefore, a single type member will always be regarded as indented with tabs, regardless of actual indentation. It's extra silly because it affected the particular use case that I implemented the indentation detection for in the first place. Now explicitly uses doubles instead for the comparison.Tiny rounding errors don't really matter here, in the general case there will either be 0 tabs or all tabs. It was just the massive rounding error of integer division of
1 / 2
that was problematic.