fix(3984): Retain simply qualified name of throwable type #555
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #554
This PR fixes a problem where the
UnusedThrowableProcessor
always creates a fully qualified name for the throwable, even when a simply qualified name is used initially. I.e. the repair looks like so:With this fix, the repair looks as intended:
In doing the exact match test to check that the printed reference is indeed simply qualified, I also discovered that comments on the thrown expression must be moved to the
CtThrow
, otherwise they are printed like this before the semicolon:And that just looks very strange.