refactor: Use full string key for Sonar rules #581
Merged
+203
−157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@khaes-kth Any chance you can have a look at this today? It's a blocker for #582 |
|
@slarse |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #580
This PR fixes the inconsistent use of rule keys internally in Sorald, where in some places an integer was used, and in others a string. Additionally, the full key is now used (e.g.
"S1854"instead of"1854"). This is due to needing the full key when interacting with Sonar, and translating back and forth is both a hassle and error prone. It also doesn't make much sense not to use the full key, it's just an element of potential confusion for users.The implementation is backwards compatible for now. That is to say, if someone were to type
--rule-key 1854or provide a violation specifier with the "shortened" rule key on the command line, that would still work.