Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Check for flow breaks before patching with the repair for S2142 #610

Merged
merged 3 commits into from
Nov 3, 2021
Merged

fix: Check for flow breaks before patching with the repair for S2142 #610

merged 3 commits into from
Nov 3, 2021

Conversation

algomaster99
Copy link
Member

Fixes: #599

@khaes-kth khaes-kth self-requested a review November 3, 2021 12:18
@khaes-kth
Copy link
Collaborator

Thanks a lot @algomaster99 . Seems to be fine.

Have you tried it on the commit I had referred to in #599 to see if it fixes the problem?

@algomaster99
Copy link
Member Author

I don't see any commit linked in that issue. There is a code block which describes the bug and I have created tests similar to it. Could you please link the commit?

@khaes-kth
Copy link
Collaborator

Oh! You're right. I'll find the commit and send you the link.

@khaes-kth
Copy link
Collaborator

khaes-kth commented Nov 3, 2021

I found it. You get that error on https://github.com/joelittlejohn/embedmongo-maven-plugin, commit 72b45f438a69c6ae575aa62c6a536a35905ef7b8.

@algomaster99
Copy link
Member Author

algomaster99 commented Nov 3, 2021

Yes, it works now! This is the line for future reference. You may merge if you don't have any further reviews.

@khaes-kth khaes-kth merged commit 6731376 into ASSERT-KTH:master Nov 3, 2021
@khaes-kth
Copy link
Collaborator

Thanks @algomaster99

@monperrus
Copy link
Contributor

great start @algomaster99

@algomaster99 algomaster99 deleted the fix-S2142 branch November 4, 2021 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Inaccessible line added for 2142 fixes
3 participants