Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add factorypath to gitignore #705

Merged
merged 1 commit into from
Jan 28, 2022

Conversation

MartinWitt
Copy link
Contributor

This was missing inside the .gitignore. The gitignore seems kinda small, have you thought about simply adding something like this https://www.toptal.com/developers/gitignore/api/java,visualstudiocode,eclipse,intellij,maven,gradle ?

@algomaster99
Copy link
Member

Hi @MartinWitt !

Thanks for your PR. I assume .factorypath is for development on Eclipse?

gitignore seems kinda small, have you thought about simply adding something like this https://www.toptal.com/developers/gitignore/api/java,visualstudiocode,eclipse,intellij,maven,gradle

I always add globs to .gitignore when I know I want to ignore them. For example, templates also ignore the jar files but in #696 we need the sonar-java.jar to execute as a sonar-lint plugin. Of course, this is one exceptional case, but I feel the generic .gitignores are more verbose than they need to be.

@MartinWitt
Copy link
Contributor Author

I assume .factorypath is for development on Eclipse?

From my understanding, the eclipse compiler generates these because vscode has no more resource files inside the project folder. In short it appears during my development.

@algomaster99 algomaster99 merged commit 44303e3 into ASSERT-KTH:master Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants