refactor: create sorald-api #783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
algomaster99
approved these changes
Apr 6, 2022
Comment on lines
-16
to
-25
|
|
||
| /** | ||
| * Create a rule based on the key. | ||
| * | ||
| * @param key A key for which to create a rule. | ||
| * @return A rule based on the key. | ||
| */ | ||
| static Rule of(String key) { | ||
| return new SonarRule(key); | ||
| } |
There was a problem hiding this comment.
It is okay we removed this from the interface. We can instead always use new SonarRule in sorald-sonar.
|
The next step is to move sorald-sonar classes to a sorald-sonar submodule, yes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR finally creates the Sorald API module. I have only included the necessary classes in the API. The
Rules#ofmethod is removed in this PR. This is a breaking change, but there is no way to really support such a method inside the rule interface.