Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: use latest release for pom_configured test #944

Merged
merged 1 commit into from
Nov 24, 2022

Conversation

algomaster99
Copy link
Member

@algomaster99 algomaster99 commented Nov 24, 2022

I removed the version tag from this test to avoid changing it every time I release sorald. One downside to this change is that we won't be testing this specific test with the latest SNAPSHOT, instead, we would be testing it with the latest release on maven central. I think it is a fine compromise to make because it is very unlikely that other integration tests will pass, but this specific test will fail.

Initially, maven had an option <version>LATEST</version> to fetch the latest SNAPSHOT at build time and use it. However, it has been deprecated in maven 3.x in favour of reproducibility.

@algomaster99 algomaster99 changed the title chore: use latest release for pom_configured test tests: use latest release for pom_configured test Nov 24, 2022
@algomaster99 algomaster99 merged commit 5438850 into master Nov 24, 2022
@algomaster99 algomaster99 deleted the use-latest-release branch November 24, 2022 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant