Merged
Conversation
BAEK0111
requested review from
2ghrms,
eeeeeaaan,
kimyw1018,
leesumin0526 and
sjhwang0
2ghrms
approved these changes
Jan 19, 2026
src/main/java/com/assu/server/domain/chat/service/ChatServiceImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/com/assu/server/domain/chat/service/ChatServiceImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/com/assu/server/domain/chat/redis/RedisPublisher.java
Outdated
Show resolved
Hide resolved
src/main/java/com/assu/server/domain/chat/redis/RedisMessageSubscriber.java
Outdated
Show resolved
Hide resolved
| this.partner = partner; | ||
| } | ||
|
|
||
| public static ChattingRoom toCreateChattingRoom(Admin admin, Partner partner) { |
Member
There was a problem hiding this comment.
어짜피 static 메소드니까 이것도 from으로 하는게 좋을 것 같습니다!
Contributor
Author
There was a problem hiding this comment.
of: 여러 파라미터를 받아서 인스턴스를 생성할 때 사용 (정적 팩토리 메서드의 일반적인 네이밍)
예: ChattingRoom.of(admin, partner)
from: 단일 객체를 변환할 때 주로 사용
예: ChattingRoom.from(chattingRoomDTO) - DTO → Entity 변환
toEntity: DTO 클래스 내부에서 자기 자신을 엔티티로 변환할 때 사용
예: chattingRoomDTO.toEntity() - DTO의 인스턴스 메서드
두 개의 엔티티를 받아서 생성하는 것이어서 of로 수정해봤습니다!
2ghrms
reviewed
Jan 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
📝작업 내용
🔎코드 설명(스크린샷(선택))
💬고민사항 및 리뷰 요구사항 (Optional)
비고 (Optional)