Merged
Conversation
- 공통 사항 수정
- 공통 및 추가 리팩토링 - map n+1 방지 - 기타 유형 another_type 추가 (paperContent Entity 수정)
leesumin0526
reviewed
Feb 7, 2026
src/main/java/com/assu/server/domain/map/converter/MapConverter.java
Outdated
Show resolved
Hide resolved
src/main/java/com/assu/server/domain/map/dto/MapResponseDTO.java
Outdated
Show resolved
Hide resolved
src/main/java/com/assu/server/domain/partnership/converter/PartnershipConverter.java
Outdated
Show resolved
Hide resolved
src/main/java/com/assu/server/domain/partnership/dto/PartnershipRequestDTO.java
Outdated
Show resolved
Hide resolved
src/main/java/com/assu/server/domain/partnership/dto/PartnershipResponseDTO.java
Outdated
Show resolved
Hide resolved
2ghrms
approved these changes
Feb 9, 2026
src/main/java/com/assu/server/domain/admin/repository/AdminRepository.java
Outdated
Show resolved
Hide resolved
| (a.department = :department AND a.major IS NULL) OR | ||
| (a.department = :department AND a.major = :major) | ||
| ) | ||
| """) |
Member
There was a problem hiding this comment.
지금 쿼리들이 인덱스가 필요한 경우가 많이 보입니다. 잊지말고 추후 개선사항에 인덱스까지 적용해서 레포지토리 쿼리를 보강합시다
| private String adminName; | ||
| private String adminUrl; | ||
| private String adminPhone; | ||
| public record AdminLiteDTO( |
src/main/java/com/assu/server/domain/partnership/converter/PartnershipConverter.java
Outdated
Show resolved
Hide resolved
| WHERE pc.paper.store.id IN :storeIds | ||
| ORDER BY pc.id DESC | ||
| """) | ||
| List<PaperContent> findTopByStoreIdIn(@Param("storeIds") List<Long> storeIds); |
Member
There was a problem hiding this comment.
추후에 Pagenation을 꼭 추가해야할 것 같습니다. 웬만하면 전체조회시 리스트를 사용하지 않도록 해야합니다.
Member
There was a problem hiding this comment.
인덱스 없는 상태에서 조건부와 JOIN을 하게 되면 추후 병목발생 가능성이 높으니 최적화 부탁드립니다.
- 모든 dto를 record로 변경
- 모든 dto를 record로 변경
- 빌드 오류 해결
- storemapresponsedto 응답 방식 변경 - 지도 내 매장조회 로직 변경
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
📝작업 내용
Map, Partnership N+1 방지
Service에 있던 빌드를 컨버터로 옮기면서 일관성 유지
StoreMapResponseDTO 응답 형식 변경 (getStores, searchStores)
🔎코드 설명(스크린샷(선택))
💬고민사항 및 리뷰 요구사항 (Optional)
비고 (Optional)