fix(app-webdir-ui): fix rendered more hooks than during previous render #1177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
|
Turns out, that's happening before the |
|
Awesome! I noticed that error every now and then, but was not able to track it down. LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@davidornelas11 This addresses an error I was seeing in Storybook where if you selected the Search Page story and it rendered, then you select a different story, and then try to go back to the Search Page, you get the error "Rendered more hooks than during previous render".
A search on that error turned up this issue, and the fix in this comment resolved the issue.
This PR implements that fix. Can you verify?