Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed sklearn version before GridSearchCV is fixed #361

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

Sinacam
Copy link
Contributor

@Sinacam Sinacam commented Feb 27, 2024

What does this PR do?

We are using a feature not supported by sklearn:

In addition, every keyword argument accepted by init should correspond to an attribute on the instance.

This PR is a temporary patch to use unsupported behaviour from sklearn 1.2.2 before a comprehensive fix can be implemented.

Test CLI & API (bash tests/autotest.sh)

Test APIs used by main.py.

  • Test Pass
    • (Copy and paste the last outputted line here.)
  • Not Applicable (i.e., the PR does not include API changes.)

Check API Document

If any new APIs are added, please check if the description of the APIs is added to API document.

  • API document is updated (linear, nn)
  • Not Applicable (i.e., the PR does not include API changes.)

Test quickstart & API (bash tests/docs/test_changed_document.sh)

If any APIs in quickstarts or tutorials are modified, please run this test to check if the current examples can run correctly after the modified APIs are released.

@Eleven1Liu Eleven1Liu added release Bump version for PyPI model/linear enhancement New feature or request, or code polishing and removed model/linear labels Feb 27, 2024
@Eleven1Liu Eleven1Liu merged commit 7106704 into ASUS-AICS:master Feb 28, 2024
1 check passed
@Eleven1Liu Eleven1Liu deleted the fix-sklearn branch February 28, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request, or code polishing release Bump version for PyPI version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants