-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Ray Argument #376
Merged
Merged
Update Ray Argument #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donglihe-hub
requested review from
cjlin1,
Eleven1Liu,
henryyang42,
JamesLYC88 and
Gordon119
as code owners
June 17, 2024 16:59
Eleven1Liu
requested changes
Jun 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please help add ray[tune] > ???
to requirements_parameter_search.txt
donglihe-hub
force-pushed
the
hp_search
branch
2 times, most recently
from
June 19, 2024 17:31
a6588ea
to
98961f4
Compare
Eleven1Liu
requested changes
Jun 20, 2024
Eleven1Liu
requested changes
Jun 20, 2024
Eleven1Liu
reviewed
Jun 20, 2024
donglihe-hub
force-pushed
the
hp_search
branch
2 times, most recently
from
June 21, 2024 08:12
8f13496
to
01e8cb5
Compare
Eleven1Liu
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Results:
Before:
After:
Test CLI & API (
bash tests/autotest.sh
)Test APIs used by main.py.
Check API Document
If any new APIs are added, please check if the description of the APIs is added to API document.
Test quickstart & API (
bash tests/docs/test_changed_document.sh
)If any APIs in quickstarts or tutorials are modified, please run this test to check if the current examples can run correctly after the modified APIs are released.