Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Ray Argument #376

Merged
merged 4 commits into from
Jun 21, 2024
Merged

Update Ray Argument #376

merged 4 commits into from
Jun 21, 2024

Conversation

donglihe-hub
Copy link
Contributor

@donglihe-hub donglihe-hub commented Jun 17, 2024

What does this PR do?

  1. Add shorthand for --config
  2. Since 2.24.0, using local_dir in ray.tune will raise an error. a minimum version requirement is set for ray[tune]. The first deprecation comment occurs in 2.5.0.
  3. Upgrade ray.tune API from 1.0 style to 2.0 because the documentation of the 1.0-style API is no longer updated.

image

image

Results:
Before:
image

image

After:
image
image

Test CLI & API (bash tests/autotest.sh)

Test APIs used by main.py.

  • Test Pass
    • (Copy and paste the last outputted line here.)
  • Not Applicable (i.e., the PR does not include API changes.)

Check API Document

If any new APIs are added, please check if the description of the APIs is added to API document.

  • API document is updated (linear, nn)
  • Not Applicable (i.e., the PR does not include API changes.)

Test quickstart & API (bash tests/docs/test_changed_document.sh)

If any APIs in quickstarts or tutorials are modified, please run this test to check if the current examples can run correctly after the modified APIs are released.

@Eleven1Liu Eleven1Liu added the bug Something isn't working label Jun 19, 2024
Copy link
Collaborator

@Eleven1Liu Eleven1Liu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please help add ray[tune] > ??? to requirements_parameter_search.txt

@donglihe-hub donglihe-hub force-pushed the hp_search branch 2 times, most recently from a6588ea to 98961f4 Compare June 19, 2024 17:31
search_params.py Outdated Show resolved Hide resolved
search_params.py Outdated Show resolved Hide resolved
search_params.py Outdated Show resolved Hide resolved
@donglihe-hub donglihe-hub force-pushed the hp_search branch 2 times, most recently from 8f13496 to 01e8cb5 Compare June 21, 2024 08:12
@Eleven1Liu Eleven1Liu merged commit 12519d0 into ASUS-AICS:master Jun 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working parameter-search
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants