Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Autotest: Set Pytorch <=2.3 to resolve torchtext dependency issue #386

Merged
merged 2 commits into from
Aug 22, 2024

Conversation

Eleven1Liu
Copy link
Collaborator

@Eleven1Liu Eleven1Liu commented Aug 22, 2024

What does this PR do?

  • Torchtext is incompatible with the latest PyTorch 2.4.0, which makes the test fail.
  • Torchtext stopped being updated in Apr. 2024, and the latest version will be fixed at 0.18.0 (compatible with Pytorch 2.3). See Pytorch/Torchtext dependency here.

Test CLI & API (bash tests/autotest.sh)

Test APIs used by main.py.

  • Test Pass
    • (Copy and paste the last outputted line here.)
  • Not Applicable (i.e., the PR does not include API changes.)

Check API Document

If any new APIs are added, please check if the description of the APIs is added to API document.

  • API document is updated (linear, nn)
  • Not Applicable (i.e., the PR does not include API changes.)

Test quickstart & API (bash tests/docs/test_changed_document.sh)

If any APIs in quickstarts or tutorials are modified, please run this test to check if the current examples can run correctly after the modified APIs are released.

@Eleven1Liu Eleven1Liu changed the title Check torchtext dependency Fix Autotest: Set Pytorch <=2.3 to resolve torchtext dependency issue Aug 22, 2024
@Eleven1Liu Eleven1Liu added release Bump version for PyPI version labels Aug 22, 2024
@Eleven1Liu Eleven1Liu merged commit 91e6a4a into ASUS-AICS:master Aug 22, 2024
1 check passed
@Eleven1Liu Eleven1Liu deleted the dependency branch August 22, 2024 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Bump version for PyPI version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants