-
Notifications
You must be signed in to change notification settings - Fork 0
Project restructuring, fixed sketch grid, and cleaned Test CMakeLists #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Turned off CXX Extensions - Added compiler flags -Wall and -Wextra - Formatting - restructured textrender and grid - sketch and text are now separate libraries
- Created vector of Vertex in CADRender for the grid line and used it for the vertex buffer - Test executives now link to just the sketch and text libraries. - Use pch_interface in the test executables - Added test_text.cpp for the text lib - Need to add back in camera tests
- got rid of installing windows sdk from build Action - Added Actions and ActionQueue to project
- Removed constants for Buffer ids and changed them to enum class BufferName - Ran clang-tidy on all the cpp files
- Changed default background color to white - Can now change background color and selection point color during runtime TODO: - Need to create settings file for saving and loading user preferences
- Removed Actions and ActionQueue -- Removed any references of Action and ActionQueue - Added Command, SketchAddPointCommand, and Mouse classes - mouse callbacks now call to Mouse::leftMouseClick() when adding points
- cleaned up .gitignore - removed unnecessary pch.hpp's in subdirectories - renamed font texture and coordinate files to more appropriate "arial.png" and "arial.csv" - added config.hpp.in for configuring local file paths to shaders and text textures/coordinates - Changed top-level CMakeLists to configure "config.hpp" and removed code that copied the shader/text files to the build directory
- Removed capital letters in cpp file names - Added cammeracommands.hpp -- Added CameraZoomCommand -- Added additional overide to Command Command::execute(double) - Scroll callback now executes mouse scroll command - Removed unneeded function updateSelectionPoints() in Cadera - Removed sketch_add_point() and sketch_move_point() in callbacks - Fixed narrowing conversion warning in selection, normalizeToVulkanCoords() - CADRender:::setBGColor() now correctly sets the value in mRenderColors - TextRender::generateQuads() now takes in the CADRender background color to ensure text background matches - Removed RenderUtil.hpp and added contents to cadrender.hpp - Removed bgColor from CADRender - Removed backgroundColor from Text struct - Grid Menu now prevents too large of input from user - Added Mouse::scroll() - Initialize SketchAddPointCommand::mCamera to nullptr - Removed unneccesary pch.hpp from test/
- Removed targeting glm for textlib CMakeLists as glm is already in pch_interface
Renaming of uppercase cpp files to all lowercase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Project restructuring, fixed sketch grid, and cleaned Test CMakeLists