Fixed 'Stones of Binding' (though it should probably be moved into BR…

…D Dungeon Location like other Dungeon quests have been...) (fixes #1013)

Candy Bar is rewarded still by a quest (fixes #986)
Removed entire Firelands Legendary quest chain from arbitrarily showing in multiple maps (fixes #929)
Added the proper mapID to 'In the Hall of the Thunder King' (fixes #472)

.contrib/Parser/DATAS/01 - Dungeons Raids/4 - Cataclysm/1 - Raids/5 Firelands.lua

@@ -82,17 +82,7 @@ root("Instances", tier(CATA_TIER, {
 				["icon"] = "Interface\\Icons\\Stave_2H_Tarecgosa_E_01StageFinal",
 				["isRaid"] = true,
 				["lvl"] = 85,
-				["maps"] = {
-					TANARIS,
-					74,	-- Tanaris: Caverns of Time Entrance
-					CAVERNS_OF_TIME,
-					STORMWIND_CITY,
-					ORGRIMMAR,
-					86,		-- Orgrimmar: The Drag
-					300,	-- The Nexus (phased)
-					MOUNT_HYJAL,
-					BOREAN_TUNDRA,
-				},
+				-- TODO: coords for all these quests
 				["g"] = sharedData({["classes"] = { PRIEST, SHAMAN, MAGE, WARLOCK, DRUID }},{
 					a(q(29453, {	-- Your Time Has Come [A]
 						["description"] = "This quest is auto accepted upon killing a Molten Lord.",

.contrib/Parser/DATAS/02 - Outdoor Zones/01 Kalimdor/02 Orgrimmar/Quests.lua

@@ -474,7 +474,7 @@ root("Zones", m(KALIMDOR, {
 				["races"] = HORDE_ONLY,
 				["u"] = REMOVED_FROM_GAME,
 			}),
-			q(28299, {	-- Meet with Kranosh
+			q(28299, {	-- Meet with Kazak Darkscream
 				["races"] = HORDE_ONLY,
 				["classes"] = { WARLOCK },
 				["isBreadcrumb"] = true,
@@ -701,11 +701,23 @@ root("Zones", m(KALIMDOR, {
 					i(191408),	-- Explosive Pie
 				},
 			})),
-			q(28459, {	-- Stones of Binding
+			q(28459, {	-- Stones of Binding -- TODO: Move to BRD?
 				["sourceQuests"] = { 28299 },	-- Meet with Kranosh
-				["provider"] = { "n", 88705 },	-- Kranosh
+				["qgs"] = {
+					-- #IF AFTER SHADOWLANDS
+					168623,	-- Kazak Darkscream
+					-- #ELSE
+					88705,	-- Kranosh
+					-- #ENDIF
+				},
+				["coords"] = {
+					-- #IF AFTER SHADOWLANDS
+					{ 74.6, 47.4, ORGRIMMAR },
+					-- #ELSE
+					{ 49.0, 55.2, ORGRIMMAR },
+					-- #ENDIF
+				},
 				["classes"] = { WARLOCK },
-				["coord"] = { 49.0, 55.2, ORGRIMMAR },
 				["races"] = HORDE_ONLY,
 				["g"] = {
 					i(65627),	-- Horns of the Left Hand Path

.contrib/Parser/DATAS/02 - Outdoor Zones/04 Northrend/Zul'Drak/Quests.lua

@@ -345,10 +345,10 @@ _.Zones =
 					["sourceQuest"] = 12661,	-- Infiltrating Voltarus
 				}),
 				q(13099, {	-- Just Checkin'
-					["u"] = REMOVED_FROM_GAME,
 					["provider"] = { "n", 28527 },	-- Chronicler To'kini
+					["timeline"] = { "added 3.3.0.10772", "removed 4.3.0.14732" },
 				}),
-				q(29836, {	-- Just Checkin' -- aa
+				q(29836, {	-- Just Checkin'
 					["coord"] = { 59.9, 57.9, ZULDRAK },
 					["provider"] = { "n", 28527 },	-- Chronicler To'kini
 					["altQuests"] = { 29833 },	-- Unfinished Business
@@ -741,6 +741,7 @@ _.Zones =
 						i(39838),	-- Supple Belt of the Bloodletter
 						i(39796),	-- Boots of the Great Sacrifice
 						i(39798),	-- Ring of Ancestral Protectors
+						i(20390),	-- Candy Bar
 					},
 				}),
 				q(12796, {	-- The Magical Kingdom of Dalaran -- aa

.contrib/Parser/DATAS/05 - Achievements/13 - Legacy/01 - General.lua

@@ -90,13 +90,14 @@ root("Achievements", achcat(ACHIEVEMENT_CATEGORY_LEGACY, {
 		un(REMOVED_FROM_GAME, a(ach(8336))),	-- I've Got the Biggest Brawls of Them All (Season 1) (Alliance) **Can't find any commentary on whether this is still available in Legion season or not.**
 		un(REMOVED_FROM_GAME, h(ach(8338))),	-- I've Got the Biggest Brawls of Them All (Season 1) (Horde) **Can't find any commentary on whether this is still available in Legion season or not.**
 		ach(8106, {				-- In the Hall of the Thunder King
+			["maps"] = { 518 },	-- Thunder King's Citadel -- TODO: move this to the map file itself (which doesn't exist yet)
 			["groups"] = {
 				crit(1),			-- Obtain a Handful of Stolen Gems from the Treasure Saurok
 				crit(2),			-- Loot 10 Golden Treasure Chests in one run
 				crit(3),			-- Slay God-Hulk Gulkan
 				crit(4),			-- Reach Tenwu of the Red Smoke
 			},
-			["classes"] = { ROGUE },
+			-- removed 'classes' since I've found no evidence this is restricted to Rogues...
 		}),
 		un(REMOVED_FROM_GAME, ach(11572)),		-- I Am Thrall's Complete Lack Of Surprise(Legion)
 		un(REMOVED_FROM_GAME, ach(2923)),		-- Iron Dwarf, Medium Rare (10 player)

.contrib/Parser/DATAS/06 - Expansion Features/06 Legion/Legion Class Halls/The Hall Of Shadows (Rogue).lua

@@ -41,7 +41,7 @@ root("ExpansionFeatures", tier(LEGION_TIER, bubbleDown({ ["timeline"] = { "added
 						gt(441, {	-- The Vault
 							n(98100, {	-- Taoshi
 								["coord"] = { 40.8, 76.8, THE_HALL_OF_SHADOWS },
-								["cost"] = { { "i", 94222, 1} },	-- 1xKey to the Palace of Lei Shen
+								["cost"] = { { "i", 94222, 1} },	-- 1x Key to the Palace of Lei Shen
 								["maps"] = { 518 },	-- Thunder King's Citadel
 								["g"] = {
 									i(95497, {	-- Burial Trove Key